Review main Merged

64069[BUGFIX] Allow protocol-relative urls in AssetRenderer

Christian Eßl CR +2 V +2 Easy +1 −1 updated 04/06/20, 09:39

Commit message

Allow including protocol-relative urls (urls that start with "//") in
the new AssetRenderer in the same way as it is already supported in
other parts of TYPO3.

Keep in mind, that using protocol-relative urls is considered an
antipattern nowadays and if you run your website solely on encrypted
connections (which you should by now), you can and should always request
all resources via https://.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Eßl uploaded patch set 1 04/04/20, 12:22

  2. TYPO3com voted on patch set 1 V +1 04/04/20, 12:34 Completed build in 12m 03s on Sat, 4 Apr, 12:34 PM Test Summary: 73288 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2157

  3. Oli Bartsch commented on patch set 1 V +1 CR +1 04/04/20, 12:49

    But I'm still unsure if the commit message is sufficient as documentation..
  4. Guido Schmechel voted on patch set 1 CR +1 04/04/20, 13:12

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/06/20, 09:39

  6. Benni Mack merged patch set 2 04/06/20, 09:39