Review main Merged

64070[DOCS][BUGFIX] Fix docs on how to set a fallback og:image

Christian Eßl CR +2 V +2 Easy +14 −4 updated 04/06/20, 08:32

Commit message

The current solution for setting a fallback og:image/twitter:image in
the docs of ext:seo would generate relative urls, which is not desired
for these kind of resources. Improve the docs with a solution, that
enforces absolute urls.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Eßl uploaded patch set 1 04/04/20, 13:16

  2. TYPO3com voted on patch set 1 V +1 04/04/20, 13:28 Completed build in 12m 08s on Sat, 4 Apr, 01:28 PM Test Summary: 73288 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2162

  3. Daniel Siepmann voted on patch set 1 V +1 CR +1 04/06/20, 08:25

  4. Richard Haeser voted on patch set 1 V +2 CR +2 04/06/20, 08:32

  5. Richard Haeser merged patch set 2 04/06/20, 08:32