Review main Merged

64071[FEATURE] Implement event for LocalizationController column building

Claus Due CR +2 V +2 Normal +160 −4 updated 04/20/20, 13:16

Commit message

Implements a PSR-14 event dispatched after
LocalizationController has built the manifest of columns
and column numbers, allowing third parties to change
this manifest without XCLASS'ing LocalizationController.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benni Mack +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 3242

Show 1417 earlier messages
  1. Claus Due uploaded patch set 1 04/04/20, 13:45

  2. TYPO3com voted on patch set 1 V +1 04/04/20, 13:58 Completed build in 12m 28s on Sat, 4 Apr, 01:58 PM Test Summary: 73288 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2163

  3. Benni Mack commented on patch set 1 04/17/20, 12:58

    Can you rebase this one and create a RST (as it is a feature)
  4. Benni Mack uploaded patch set 2 04/17/20, 23:28

  5. Benni Mack commented on patch set 2 04/17/20, 23:28

    Hey Claus, can you describe why this Event needs to be "Stoppable"?
  6. TYPO3com voted on patch set 2 V -1 04/17/20, 23:48 Completed build in 17m 03s on Fri, 17 Apr, 11:48 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2767

  7. Claus Due commented on patch set 2 04/18/20, 10:31

    > Patch Set 2: > > Hey Claus, can you describe why this Event needs to be "Stoppable"? I thought it would be nice to allow third parties to have a final say in whether the event continues, in part because that's something we couldn't do (easily) with legacy hooks and because it didn't add much to the complexity. But it looks like I should have implemented a "stopPropagation" method as well to make that actually work. We can either remove the interface or add this method - whichever you prefer. There's no current use case which calls for being able to stop this particular event, but I only have a single use case (nested content) as reference.
  8. Benni Mack commented on patch set 2 04/18/20, 12:28

    > Patch Set 2: > > > Patch Set 2: > > > > Hey Claus, can you describe why this Event needs to be "Stoppable"? > > I thought it would be nice to allow third parties to have a final say in whether the event continues, in part because that's something we couldn't do (easily) with legacy hooks and because it didn't add much to the complexity. But it looks like I should have implemented a "stopPropagation" method as well to make that actually work. > > We can either remove the interface or add this method - whichever you prefer. There's no current use case which calls for being able to stop this particular event, but I only have a single use case (nested content) as reference. We could add the stoppable later on then I suggest. Both ok for now
  9. Claus Due uploaded patch set 3 04/19/20, 10:51

  10. Claus Due commented on patch set 3 04/19/20, 10:51

    * Rebased on master * Added feature RST * Relabled as FEATURE
  11. Claus Due commented on patch set 3 04/19/20, 10:52

    > Patch Set 3: > > * Rebased on master > * Added feature RST > * Relabled as FEATURE ...and removed use of Stoppable along with method associated with Stoppable.
  12. TYPO3com voted on patch set 3 V +1 04/19/20, 11:03 Completed build in 11m 58s on Sun, 19 Apr, 11:03 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2838

  13. Georg Ringer voted on patch set 3 V +1 CR +1 04/19/20, 17:09

  14. Benni Mack commented on patch set 3 CR -2 04/19/20, 19:44

    I'll rebase this one, once the "Refactor fluid page module components" is in.
  15. Oliver Hader commented on patch set 3 04/20/20, 09:10

    > Patch Set 3: Code-Review-2 > > I'll rebase this one, once the "Refactor fluid page module components" is in. → https://review.typo3.org/c/Packages/TYPO3.CMS/+/64002
  16. Benni Mack uploaded patch set 4 04/20/20, 09:22

  17. Oliver Hader voted on patch set 3 CR +1 04/20/20, 09:22

  1. Benni Mack voted on patch set 4 V +1 CR +1 04/20/20, 09:22

  2. Benni Mack uploaded patch set 5 04/20/20, 09:23

  3. Oliver Klee commented on patch set 5 04/20/20, 09:23

    To me, this sounds more like a [FEATURE].
  4. Benni Mack updated the commit message in patch set 6 04/20/20, 09:23

  5. Benni Mack commented on patch set 6 04/20/20, 09:24

    Reply Unresolved

    As usual: Big thanks, Oli!
  6. Benni Mack voted on patch set 6 V +1 CR +1 04/20/20, 09:25

  7. Oliver Hader commented on patch set 6 04/20/20, 09:25

    AfterPageColumnsSelectedForLocalizationEvent.php:56

    Is that required? Or just when implementing the corresponding interface?
  8. Claus Due commented on patch set 6 04/20/20, 09:25

    AfterPageColumnsSelectedForLocalizationEvent.php:56 Reply Unresolved

    Should be removed!
  9. Benni Mack commented on patch set 6 04/20/20, 09:25

    on it
  10. Benni Mack uploaded patch set 7 04/20/20, 09:26

  11. Claus Due commented on patch set 7 04/20/20, 09:26

    AfterPageColumnsSelectedForLocalizationEvent.php:31

    Should these be annotated?
  12. Benni Mack commented on patch set 7 04/20/20, 09:27

    AfterPageColumnsSelectedForLocalizationEvent.php:31 Reply Unresolved

    Hey Claus, I guess so. maybe you could also add a small description on what the properties contain?
  13. TYPO3com voted on patch set 4 V -1 04/20/20, 09:38 Completed build in 15m 37s on Mon, 20 Apr, 09:38 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2878

  14. TYPO3com voted on patch set 5 V -1 04/20/20, 09:46 Completed build in 23m 46s on Mon, 20 Apr, 09:46 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2880

  15. TYPO3com voted on patch set 6 V -1 04/20/20, 09:53 Completed build in 16m 46s on Mon, 20 Apr, 09:53 AM Test Summary: 1 of 74112 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2881

  16. TYPO3com voted on patch set 7 V -1 04/20/20, 09:57 Completed build in 20m 57s on Mon, 20 Apr, 09:57 AM Test Summary: 1 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2882

  17. TYPO3com commented on patch set 7 04/20/20, 10:19 Completed build in 1h 04m 12s on Mon, 20 Apr, 10:19 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2882

  18. Claus Due uploaded patch set 8 04/20/20, 10:39

  19. TYPO3com voted on patch set 8 V -1 04/20/20, 10:50 Completed build in 11m 29s on Mon, 20 Apr, 10:50 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2886

  20. Claus Due uploaded patch set 9 04/20/20, 10:57

  21. TYPO3com voted on patch set 9 V +1 04/20/20, 11:10 Completed build in 12m 19s on Mon, 20 Apr, 11:10 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2887

  22. Benni Mack voted on patch set 9 V +1 CR +1 04/20/20, 11:22

  23. Frank Nägler voted on patch set 9 CR +1 04/20/20, 13:04

  24. Frank Nägler voted on patch set 9 V +2 CR +2 04/20/20, 13:16

  25. Frank Nägler merged patch set 10 04/20/20, 13:16