Review main Merged

64075[BUGFIX] Declare method of AspectFactory in matcher

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 04/05/20, 09:26

Commit message

The patch for #88720 added a new entry in MethodArgumentRequiredMatcher
to cover changes in the class AspectFactory. The entry misses the
affected method name which broke the extension scanner.

This patch declares the missing affected method.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 78

  1. Andreas Kienast uploaded patch set 1 04/04/20, 15:04

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 04/04/20, 15:08

  3. Alexander Schnitzler voted on patch set 1 V +1 CR +1 04/04/20, 15:13

  4. TYPO3com voted on patch set 1 V +1 04/04/20, 15:16 Completed build in 12m 04s on Sat, 4 Apr, 03:16 PM Test Summary: 73334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2170

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 04/04/20, 15:17

  6. Andreas Kienast merged patch set 2 04/04/20, 15:17

  7. Oliver Hader voted on patch set 2 CR +1 04/05/20, 09:22

  8. Oliver Hader commented on patch set 2 04/05/20, 09:26

    The definition previously was in ConstructorArgumentMatcher - I forgot to move it and test Extension Scanner again... Good catch & great you found and fixed it!