Review main Merged

64077[BUGFIX] Remove $scheme from LegacyLinkNotationConverter::resolve()

Christian Eßl CR +2 V +2 Easy +2 −8 updated 04/21/20, 10:52

Commit message

The code block using $scheme is never reached, because there is already
an elseif condition further above, that is true for all urls containing
":".

The last else block even states in the comment:
"special handling without a scheme"

Therefore the variable is removed to remove a bit of complexity from the
function.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Eßl uploaded patch set 1 04/04/20, 20:32

  2. TYPO3com voted on patch set 1 V -1 04/04/20, 20:32 Completed build in 23s on Sat, 4 Apr, 08:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2177

  3. Christian Eßl uploaded patch set 2 04/04/20, 20:33

  4. TYPO3com voted on patch set 2 V +1 04/04/20, 20:48 Completed build in 14m 47s on Sat, 4 Apr, 08:48 PM Test Summary: 73336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2178

  5. Benni Mack voted on patch set 2 CR +1 04/04/20, 21:11

  6. Oliver Klee commented on patch set 2 04/04/20, 21:22

    LegacyLinkNotationConverter.php:137

    The indentation looks off here.
  7. Markus Klein voted on patch set 2 CR +1 04/04/20, 21:35

  8. Andreas Kienast commented on patch set 2 CR +1 04/05/20, 05:32

    LegacyLinkNotationConverter.php:137 Reply Unresolved

    The indentation is fine as the comment is related to the elseif
  9. Benni Mack voted on patch set 2 V +1 04/21/20, 10:49

  10. Georg Ringer voted on patch set 2 V +2 CR +2 04/21/20, 10:52

  11. Georg Ringer merged patch set 3 04/21/20, 10:52