Review 9.5 Merged

64079[TASK] Move ExceptionHandler tests into real class instances

Andreas Kienast CR +2 V +2 Normal +115 −69 updated 04/05/20, 07:39

Commit message

The accessibleMockForAbstractClasses is a discouraged concept
anyways, and in this case the constructor definition in the
interface caused a test failure.
Moving the tests to concrete classes solves the failure and
also gets rid of the abstract class mock.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 46

  1. Andreas Kienast uploaded patch set 1 04/05/20, 06:40

  2. Andreas Kienast uploaded patch set 2 04/05/20, 06:41

  3. TYPO3com voted on patch set 1 V +1 04/05/20, 06:58 Completed build in 17m 37s on Sun, 5 Apr, 06:58 AM Test Summary: 74724 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-421

  4. TYPO3com voted on patch set 2 V +1 04/05/20, 07:08 Completed build in 14m 57s on Sun, 5 Apr, 07:08 AM Test Summary: 74694 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-422

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 04/05/20, 07:39

  6. Andreas Kienast merged patch set 3 04/05/20, 07:39