64082[BUGFIX] Reset plugin related fields on CType change
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 5
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-79427-ResetPluginRelatedFieldsOnCTypeChange.rstnew+37 −0
- typo3/sysext/frontend/Classes/Hooks/ResetPluginRelatedFieldsHook.phpnew+59 −0
- typo3/sysext/frontend/ext_localconf.php+5 −0
Review log 917
-
Oli Bartsch uploaded patch set 1 04/05/20, 18:24
-
TYPO3com voted on patch set 1 V -1 04/05/20, 18:25 Completed build in 31s on Sun, 5 Apr, 06:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2198
-
Oli Bartsch uploaded patch set 2 04/05/20, 18:27
-
Christian Eßl commented on patch set 2 04/05/20, 18:34
With the deprecation of switchableControllerActions there will likely be more solutions, where an extensions adds multiple plugin types, that are mostly similar in their flexform configurations. With this change, switching around between two plugins would always reset all the settings the user made in a flexform. There are certainly cases, where keeping the flexform can lead to weird bugs (especially with switchableControllerActions, that are kept from a different plugin, but those are deprecated now), but in many other cases I think this would hurt usability. -
Oli Bartsch commented on patch set 2 04/05/20, 18:37
> Patch Set 2: > > With the deprecation of switchableControllerActions there will likely be more solutions, where an extensions adds multiple plugin types, that are mostly similar in their flexform configurations. > With this change, switching around between two plugins would always reset all the settings the user made in a flexform. There are certainly cases, where keeping the flexform can lead to weird bugs (especially with switchableControllerActions, that are kept from a different plugin, but those are deprecated now), but in many other cases I think this would hurt usability. Maybe we should just reset the `list_type` as this is the field which leads to the bugs reported in the issues. What do you think? -
Oli Bartsch commented on patch set 2 04/05/20, 18:43
> Patch Set 2: > > > Patch Set 2: > > > > With the deprecation of switchableControllerActions there will likely be more solutions, where an extensions adds multiple plugin types, that are mostly similar in their flexform configurations. > > With this change, switching around between two plugins would always reset all the settings the user made in a flexform. There are certainly cases, where keeping the flexform can lead to weird bugs (especially with switchableControllerActions, that are kept from a different plugin, but those are deprecated now), but in many other cases I think this would hurt usability. > > Maybe we should just reset the `list_type` as this is the field which leads to the bugs reported in the issues. What do you think? I mean the `list_type` is directly related to the CType `list` and is by default only used for this type. So I think at least this field should be cleared when changing the CType. -
TYPO3com voted on patch set 2 V -1 04/05/20, 18:45 Completed build in 18m 23s on Sun, 5 Apr, 06:45 PM Test Summary: 72534 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2199
-
TYPO3com voted on patch set 2 V +1 04/05/20, 19:09 Completed build in 17m 24s on Sun, 5 Apr, 07:09 PM Test Summary: 73364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2200
-
Oli Bartsch uploaded patch set 3 04/06/20, 18:47
-
TYPO3com voted on patch set 3 V +1 04/06/20, 19:06 Completed build in 18m 58s on Mon, 6 Apr, 07:06 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2241
-
Oli Bartsch uploaded patch set 4 04/14/20, 12:09
-
TYPO3com voted on patch set 4 V -1 04/14/20, 12:23 Completed build in 13m 59s on Tue, 14 Apr, 12:23 PM Test Summary: 73139 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2494
-
TYPO3com commented on patch set 4 04/14/20, 18:24 Completed build in 12m 20s on Tue, 14 Apr, 06:24 PM Test Summary: 1 of 74004 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2529
-
TYPO3com voted on patch set 4 V +1 04/15/20, 06:47 Completed build in 16m 11s on Wed, 15 Apr, 06:47 AM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2548
-
Benni Mack updated the commit message in patch set 5 05/30/20, 17:57
-
TYPO3com voted on patch set 5 V +1 05/30/20, 18:13 Completed build in 15m 35s on Sat, 30 May, 06:13 PM Test Summary: 73007 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3700
-
Oli Bartsch abandoned the change 08/01/20, 10:17
There is more to consider see e.g. https://forge.typo3.org/issues/88908. In the meantime reset plugin fields can be implemented by 3rd party if needed.