Review main Merged

64083[TASK] Remove internal Extbase Object Container code

Benni Mack CR +2 V +2 Normal +14 −122 updated 04/12/20, 10:32

Commit message

Since the ObjectManagerInterface methods.
- isRegistered()
- getScope()

are internal, they are substituted by PHP's internal code, and avoid
look ups to the custom ObjectContainer code.

Two constants and further methods about Singleton checks
within Extbase's internal ObjectContainer are removed as they
are now unused as well.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Alexander Schnitzler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1014

  1. Benni Mack uploaded patch set 1 04/05/20, 20:44

  2. TYPO3com voted on patch set 1 V -1 04/05/20, 21:05 Completed build in 20m 33s on Sun, 5 Apr, 09:05 PM Test Summary: 3 of 73850 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2207

  3. TYPO3com commented on patch set 1 04/06/20, 15:58 Completed build in 19h 33m 50s on Mon, 6 Apr, 03:58 PM Test Summary: 3 of 73850 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2207

  4. Benni Mack uploaded patch set 2 04/11/20, 21:20

  5. Benni Mack uploaded patch set 3 04/11/20, 21:29

  6. Benni Mack wrote 04/11/20, 21:29

    Topic set to Extbase
  7. Benni Mack wrote 04/11/20, 21:29

    Topic Extbase removed
  8. Benni Mack wrote 04/11/20, 21:30

    Topic set to extbase
  9. TYPO3com voted on patch set 2 V -1 04/11/20, 21:33 Completed build in 11m 55s on Sat, 11 Apr, 09:33 PM Test Summary: 24 of 73853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2381

  10. TYPO3com voted on patch set 3 V +1 04/11/20, 21:40 Completed build in 11m 02s on Sat, 11 Apr, 09:40 PM Test Summary: 73357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2382

  11. Andreas Kienast voted on patch set 3 CR +1 04/12/20, 05:38

  12. Alexander Schnitzler voted on patch set 3 V +1 CR +1 04/12/20, 10:26

  13. Anja Leichsenring voted on patch set 3 V +2 CR +2 04/12/20, 10:32

  14. Anja Leichsenring merged patch set 4 04/12/20, 10:32