Review main Merged

64085[BUGFIX] Fixed order-by while querying old realurl table for slugs

Riny van Tiggelen CR +2 V +2 Easy +4 −3 updated 05/19/20, 09:46

Commit message

The old tx_realurl_pathcache does not have a uid field, but uses the
field cache_id. The order-by now uses a different field depending on
the table.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Richard Haeser +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Riny van Tiggelen uploaded patch set 1 04/06/20, 09:01

  2. TYPO3com voted on patch set 1 V -1 04/06/20, 09:15 Completed build in 14m 18s on Mon, 6 Apr, 09:15 AM Test Summary: 70984 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2219

  3. TYPO3com voted on patch set 1 V +1 04/06/20, 09:49 Completed build in 21m 34s on Mon, 6 Apr, 09:49 AM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2221

  4. Oliver Klee commented on patch set 1 04/06/20, 09:55

    PopulatePageSlugs.php:227

    Should that be "identityField" instead?
  5. Riny van Tiggelen uploaded patch set 2 04/06/20, 10:09

  6. Riny van Tiggelen commented on patch set 2 04/06/20, 10:10

    PopulatePageSlugs.php:227 Reply

    Done
  7. Richard Haeser voted on patch set 2 CR +1 04/06/20, 10:21

  8. TYPO3com voted on patch set 2 V +1 04/06/20, 10:26 Completed build in 17m 21s on Mon, 6 Apr, 10:26 AM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2224

  9. Guido Schmechel voted on patch set 2 CR +1 04/18/20, 10:53

  10. Richard Haeser voted on patch set 2 V +1 05/18/20, 17:11

  11. Daniel Siepmann voted on patch set 2 CR +1 05/19/20, 09:32

  12. Benni Mack voted on patch set 2 V +2 CR +2 05/19/20, 09:46

  13. Benni Mack merged patch set 3 05/19/20, 09:46