Review main Merged

64087[TASK] Restructure and fine-tune builds

Andreas Kienast CR +2 V +2 Hard +109 −390 updated 04/08/20, 05:14

Commit message

This patch updates the Docker configuration to use mssql 2019 as mssql
2017 images don't get updates anymore.

Additionally to the mssql update, the shuffled chunking to 50 jobs is
reverted as it didn't bring any benefit but even more hassle as the
stages failed earlier and more often. Instead, the jobs are now grouped
by PHP version which allows smaller chunks and reduced the probability to
clog the build queue.

To workaround errors thrown by Gerrit on heavy load, the cherry-pick
command is now executed up to five times, with a short sleep between each
execution.

Last but not least we check whether there is actually a dangling Docker
container instead of hard killing non-existent containers which pollutes
our log.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1119

  1. Andreas Kienast uploaded patch set 1 04/06/20, 12:58

  2. TYPO3com voted on patch set 1 V +1 04/06/20, 13:17 Completed build in 19m 21s on Mon, 6 Apr, 01:17 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2230

  3. Andreas Kienast uploaded patch set 2 04/06/20, 15:56

  4. TYPO3com voted on patch set 2 V +1 04/06/20, 16:13 Completed build in 14m 16s on Mon, 6 Apr, 04:13 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2236

  5. Andreas Kienast uploaded patch set 3 04/06/20, 17:16

  6. TYPO3com voted on patch set 3 V -1 04/06/20, 17:29 Completed build in 12m 39s on Mon, 6 Apr, 05:29 PM Test Summary: 72853 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2238

  7. TYPO3com commented on patch set 3 04/06/20, 18:11 Completed build in 31m 47s on Mon, 6 Apr, 06:10 PM Test Summary: 281646 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-7

  8. TYPO3com commented on patch set 3 04/06/20, 20:29 Completed build in 3h 22m 12s on Mon, 6 Apr, 08:29 PM Test Summary: 364998 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-7

  9. Andreas Kienast uploaded patch set 4 04/07/20, 05:09

  10. Andreas Kienast uploaded patch set 5 04/07/20, 05:20

  11. Andreas Kienast uploaded patch set 6 04/07/20, 05:21

  12. TYPO3com voted on patch set 5 V +1 04/07/20, 05:34 Completed build in 13m 06s on Tue, 7 Apr, 05:34 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTC-15

  13. TYPO3com commented on patch set 5 04/07/20, 05:47 Completed build in 25m 06s on Tue, 7 Apr, 05:47 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2251

  14. TYPO3com voted on patch set 6 V +1 04/07/20, 05:52 Completed build in 29m 23s on Tue, 7 Apr, 05:52 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2252

  15. Susi Moog voted on patch set 6 V +1 CR +1 04/07/20, 06:10

  16. Andreas Kienast commented on patch set 6 CR -2 04/07/20, 06:14

    Anja wanted to take a look this evening. I'll merge and deploy tomorrow morning.
  17. Anja Leichsenring commented on patch set 6 V +1 CR +1 04/07/20, 18:32

    looks good, thanks for the work here!
  18. Andreas Kienast voted on patch set 6 V +2 CR +2 04/08/20, 05:14

  19. Andreas Kienast merged patch set 7 04/08/20, 05:14