Review main Merged

64088[BUGFIX] Fix thrown exception in history

Patrick Broens CR +2 V +2 Easy +2 −1 updated 04/07/20, 03:57

Commit message

When a logged in backend user is entering the history/undo functionality
for a certain page, which contains a deleted one, the backend user
authentication will throw an error.

This is due to the fact the pid field is not taken into account when
fetching the pages to check if they are deleted. This pid field will be
used to calculate the page access, but is now done with the value null.

This patch will add the pid field when fetching the subpages which will
be checked if they are deleted.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Patrick Broens uploaded patch set 1 04/06/20, 15:17

  2. Benni Mack voted on patch set 1 V +1 CR +1 04/06/20, 15:38

  3. Benni Mack commented on patch set 1 04/06/20, 15:39

    Thanks a bunch!
  4. TYPO3com voted on patch set 1 V -1 04/06/20, 15:51 Completed build in 24m 10s on Mon, 6 Apr, 03:51 PM Test Summary: 6 of 73851 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2233

  5. TYPO3com voted on patch set 1 V +1 04/06/20, 16:20 Completed build in 1h 17m 07s on Mon, 6 Apr, 04:20 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2233

  6. Andreas Kienast voted on patch set 1 CR +1 04/06/20, 16:31

  7. Georg Ringer voted on patch set 1 V +2 CR +2 04/07/20, 03:57

  8. Georg Ringer merged patch set 2 04/07/20, 03:57