Review main Merged

64089[BUGFIX] Typecast value to string before applying trim()

Georg Ringer CR +2 V +2 Easy +1 −1 updated 04/07/20, 05:37

Commit message

Force value to be a string instead of null in
ConstantConfigurationParser to avoid exceptions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Georg Ringer uploaded patch set 1 04/07/20, 04:35

  2. Georg Ringer commented on patch set 1 04/07/20, 04:36

    This change is ready for review.
  3. Georg Ringer uploaded patch set 2 04/07/20, 04:39

  4. Andreas Kienast voted on patch set 2 V +1 CR +1 04/07/20, 04:40

  5. Josef Glatz voted on patch set 2 V +1 CR +1 04/07/20, 04:49

  6. TYPO3com voted on patch set 2 V -1 04/07/20, 05:00 Completed build in 25s on Tue, 7 Apr, 05:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTC-12

  7. Andreas Kienast commented on patch set 2 04/07/20, 05:01

    > Patch Set 2: Verified-1 > > Completed build in 25s on Tue, 7 Apr, 05:00 AM > Test Summary: No tests found > Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTC-12 Please ignore this error, this is just a testbed run
  8. TYPO3com voted on patch set 1 V +1 04/07/20, 05:26 Completed build in 21m 31s on Tue, 7 Apr, 05:26 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2248

  9. TYPO3com voted on patch set 2 V +1 04/07/20, 05:31 Completed build in 26m 46s on Tue, 7 Apr, 05:31 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2249

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 04/07/20, 05:37

  11. Andreas Kienast merged patch set 3 04/07/20, 05:37