Review main Merged

64091[TASK] Deprecate various GeneralUtility methods

Benni Mack CR +2 V +2 Hard +234 −88 updated 04/12/20, 10:41

Commit message

Some methods in GeneralUtility nowadays are wrappers to
native PHP methods. We encourage people to use the PHP API
directly.

* GeneralUtility::IPv6Hex2Bin()
* GeneralUtility::IPv6Bin2Hex()
* GeneralUtility::compressIPv6()
* GeneralUtility::milliseconds()

In addition, these methods are unused by Core
* GeneralUtility::linkThisUrl()
* GeneralUtility::flushDirectory()

Reasoning: In order to make our code less coupled, TYPO3 Core should
use native PHP where it makes sense, instead of relying on GeneralUtility
in all places.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Alexander Schnitzler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Alexander Schnitzler +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 915

  1. Benni Mack uploaded patch set 1 04/07/20, 09:18

  2. TYPO3com voted on patch set 1 V -1 04/07/20, 09:30 Completed build in 12m 27s on Tue, 7 Apr, 09:30 AM Test Summary: 450 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2263

  3. Benni Mack uploaded patch set 2 04/08/20, 19:14

  4. TYPO3com voted on patch set 2 V +1 04/08/20, 19:27 Completed build in 12m 53s on Wed, 8 Apr, 07:27 PM Test Summary: 73255 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2321

  5. Benni Mack uploaded patch set 3 04/11/20, 20:58

  6. TYPO3com voted on patch set 3 V +1 04/11/20, 21:09 Completed build in 10m 52s on Sat, 11 Apr, 09:09 PM Test Summary: 73261 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2380

  7. Daniel Goerz voted on patch set 3 CR +1 04/11/20, 21:47

  8. Andreas Kienast uploaded patch set 4 04/12/20, 05:31

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 04/12/20, 05:31

  10. TYPO3com voted on patch set 4 V -1 04/12/20, 05:50 Completed build in 18m 45s on Sun, 12 Apr, 05:50 AM Test Summary: 35140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2386

  11. TYPO3com commented on patch set 4 04/12/20, 06:32 Completed build in 1h 19m 55s on Sun, 12 Apr, 06:32 AM Test Summary: 60870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2386

  12. TYPO3com voted on patch set 4 V +1 04/12/20, 06:41 Completed build in 2h 29m 33s on Sun, 12 Apr, 06:41 AM Test Summary: 73343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2386

  13. Alexander Schnitzler voted on patch set 4 V +1 CR +1 04/12/20, 10:38

  14. Anja Leichsenring voted on patch set 4 V +2 CR +2 04/12/20, 10:41

  15. Anja Leichsenring merged patch set 5 04/12/20, 10:41