64093[TASK] Add methods PURGE and BAN in TYPO3\CMS\Core\Http\Request
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jonas Eberle +1
- Timo Poppinga +1
-
Verified V +2 Done
- Benni Mack +2
- Jonas Eberle +1
- Timo Poppinga +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2329
Show 34 earlier messages
-
Timo Poppinga uploaded patch set 1 04/07/20, 10:12
-
TYPO3com voted on patch set 1 V +1 04/07/20, 10:24 Completed build in 11m 41s on Tue, 7 Apr, 10:24 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2267
-
Josef Glatz commented on patch set 1 CR -1 04/07/20, 10:30
Each FEATURE needs a rST ChangeLog file https://forger.typo3.com/utilities/rst But beside that: It's more a task if I compare the change with https://review.typo3.org/c/Packages/TYPO3.CMS/+/63147Such change makes also sense to backport for 9.5 too -
Timo Poppinga updated the commit message in patch set 2 04/07/20, 10:33
-
Josef Glatz updated the commit message in patch set 3 04/07/20, 10:40
-
TYPO3com voted on patch set 2 V +1 04/07/20, 10:48 Completed build in 15m 35s on Tue, 7 Apr, 10:48 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2269
-
TYPO3com voted on patch set 3 V +1 04/07/20, 10:53 Completed build in 13m 00s on Tue, 7 Apr, 10:53 AM Test Summary: 73362 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2270
-
Oliver Klee commented on patch set 3 04/07/20, 12:01
Can we please have tests that checks that the method now is supported? -
Josef Glatz commented on patch set 3 04/07/20, 13:35
> Patch Set 3: > > Can we please have tests that checks that the method now is supported? Do we have tests for other methods already? -
Timo Poppinga commented on patch set 3 04/07/20, 13:36
> Patch Set 3: > > > Patch Set 3: > > > > Can we please have tests that checks that the method now is supported? > > Do we have tests for other methods already? NOReply
DoneReply
@Glatz: yes make sense but do not know the process -
Josef Glatz commented on patch set 3 04/07/20, 20:09
Reply
Done -
Josef Glatz wrote 04/08/20, 04:22
Removed reviewer Josef Glatz. -
Georg Ringer voted on patch set 3 V +1 CR +1 04/08/20, 19:23
-
Daniel Goerz voted on patch set 3 CR +1 04/08/20, 20:11
-
Josef Glatz voted on patch set 3 V +1 CR +1 04/08/20, 21:36
-
Tymoteusz Motylewski commented on patch set 3 04/10/20, 20:44
Shouldnt also BAN be supported? -
Benni Mack commented on patch set 3 04/11/20, 23:06
> Patch Set 3: > > Shouldnt also BAN be supported? Agreed! -
Georg Ringer uploaded patch set 4 04/12/20, 19:20
-
Timo Poppinga voted on patch set 4 V +1 CR +1 04/12/20, 19:24
-
TYPO3com voted on patch set 4 V +1 04/12/20, 19:32 Completed build in 11m 41s on Sun, 12 Apr, 07:32 PM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2404
-
Benni Mack commented on patch set 4 04/12/20, 19:43
Let's add this for now and remove all supported methods in TYPO3 v11 completely - this is not necessary according to the PSR-7 spec. -
Georg Ringer uploaded patch set 5 04/12/20, 19:45
-
Georg Ringer uploaded patch set 6 04/12/20, 19:45
-
TYPO3com voted on patch set 5 V -1 04/12/20, 19:45 Completed build in 24s on Sun, 12 Apr, 07:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2407
-
TYPO3com voted on patch set 6 V +1 04/12/20, 19:58 Completed build in 12m 24s on Sun, 12 Apr, 07:58 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2408
-
Jonas Eberle voted on patch set 6 V +1 CR +1 04/12/20, 20:04
-
Timo Poppinga voted on patch set 6 V +1 CR +1 04/12/20, 20:07
-
Benni Mack voted on patch set 6 V +2 CR +2 04/12/20, 22:12
-
Benni Mack merged patch set 7 04/12/20, 22:12