Review main Merged

64094[BUGFIX] Use single type @var in LogEntry model properties

Daniel Siepmann CR +2 V +2 Easy +12 −2 updated 04/07/20, 16:15

Commit message

With https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018
several @var annotations have been adjusted to reflect the
actual used type of properties.

This however led to the issue that several properties of
Extbase models had one type as annotation but used more
than one specific type internally. Adding the additional
type made phpstan happy but broke the property mapper of
Extbase, which expects just one type to be annotated via
@var.

Therefore, the @var annotations in the affected models
have been reverted to their original state and the
reoccurring errors have been put onto phpstans list of
ignored errors.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1318

  1. Daniel Siepmann uploaded patch set 1 04/07/20, 10:29

  2. TYPO3com voted on patch set 1 V -1 04/07/20, 10:41 Completed build in 12m 25s on Tue, 7 Apr, 10:41 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2268

  3. Daniel Siepmann uploaded patch set 2 04/07/20, 10:45

  4. Alexander Schnitzler wrote 04/07/20, 10:47

    Topic set to phpstan
  5. Alexander Schnitzler commented on patch set 2 V +1 CR -1 04/07/20, 10:47

    phpstan.neon:129

    This needs to be added further upwards as these are excludes for a level 3 rule. besides that: thanks and thumbs up.
  6. TYPO3com voted on patch set 2 V +1 04/07/20, 11:03 Completed build in 13m 25s on Tue, 7 Apr, 11:03 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2272

  7. Oli Bartsch voted on patch set 2 V +1 04/07/20, 11:27

  8. Daniel Siepmann uploaded patch set 3 04/07/20, 12:07

  9. Daniel Siepmann commented on patch set 3 04/07/20, 12:08

    phpstan.neon:129 Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 04/07/20, 12:19 Completed build in 11m 51s on Tue, 7 Apr, 12:19 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2274

  11. Georg Ringer commented on patch set 3 04/07/20, 12:34

    please use a commit msg title which describes what you fix, not what is wrong
  12. Daniel Siepmann updated the commit message in patch set 4 04/07/20, 14:24

  13. TYPO3com voted on patch set 4 V +1 04/07/20, 14:36 Completed build in 11m 56s on Tue, 7 Apr, 02:36 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2275

  14. Alexander Schnitzler updated the commit message in patch set 5 04/07/20, 14:48

  15. Alexander Schnitzler voted on patch set 5 V +1 CR +1 04/07/20, 14:50

  16. TYPO3com voted on patch set 5 V +1 04/07/20, 15:00 Completed build in 11m 40s on Tue, 7 Apr, 03:00 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2276

  17. Georg Ringer voted on patch set 5 V +2 CR +2 04/07/20, 16:14

  18. Georg Ringer merged patch set 6 04/07/20, 16:15