Review main Abandoned

64098[FEATURE] Control language overlay behaviour for Insert Records element

Georg Ringer CR 0 V 0 Normal +66 −1 updated 07/22/22, 13:05

Commit message

Since 9.5 the language overlay is applied automatically which makes it
impossible to show a content element or any other selected record from
other languages.

A new checkbox can be used by editors to disable the language overlay.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 2128

Show 23 earlier messages
  1. Georg Ringer uploaded patch set 1 04/07/20, 21:29

  2. TYPO3com voted on patch set 1 V +1 04/07/20, 21:41 Completed build in 11m 55s on Tue, 7 Apr, 09:41 PM Test Summary: 73362 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2286

  3. Oli Bartsch commented on patch set 1 04/07/20, 21:55

    Important-87982-LanguageOverlayForRecordsInInsertRecordElement.rst:1

    Shouldn't this got into "Changelog/master/" first?

    tt_content.php:1056 Unresolved

    Should we also add the description from your extension to clarify what this checkbox really does? Just thinking about editors which are not so familiar with the term "language overlay". Maybe we could also just adjust the label to be more clear.
  1. Georg Ringer commented on patch set 1 04/08/20, 04:36

    As this should be backported, we place the rst there. I am not so sure yet about the wording, that is why I left the description yet
  2. Josef Glatz commented on patch set 1 CR -1 04/08/20, 05:09

    Important-87982-LanguageOverlayForRecordsInInsertRecordElement.rst:1 Reply

    I think you‘re right Oliver! Master first, then moving it while backport.

    RecordsContentObject.php:98 Unresolved

    New property needs to be added to tsref.xml
  3. Josef Glatz commented on patch set 1 04/08/20, 06:21

    Important-87982-LanguageOverlayForRecordsInInsertRecordElement.rst:1 Reply

    Done, Georg was right. I noticed it wrong
  4. Georg Ringer uploaded patch set 2 04/08/20, 08:25

  5. Josef Glatz commented on patch set 2 04/08/20, 08:34

    locallang_ttc.xlf:465 Unresolved

    is there any chance to not have a true-means-disabled? What about setting default value to 1 in DB and renaming this to enable_language_overlay?
  6. Markus Klein commented on patch set 2 04/08/20, 08:52

    Important-87982-LanguageOverlayForRecordsInInsertRecordElement.rst:4 Unresolved

    Translation behaviour for Insert Record content elements is adjustable
  7. TYPO3com voted on patch set 2 V +1 04/08/20, 08:58 Completed build in 27m 05s on Wed, 8 Apr, 08:58 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2290

  8. Benni Mack commented on patch set 2 04/08/20, 09:03

    I will look into it - I guess we should inject a custom LanguageAspect and setting the "overlayType" (as TypoScript property) in there.
  9. Georg Ringer commented on patch set 2 04/08/20, 11:24

    > I will look into it - I guess we should inject a custom LanguageAspect and setting the "overlayType" (as TypoScript property) in there. I am not really sure about that. IMO the editor must have the option to insert a record with a sys_language which is not even related to the language of current page Having languages Default EN DE: Fallback to EN RU: Strict FR: Fallback to DE IMO an editor must have the option to render on DE page even a record of RU or FR. Otherwise we would again have the situation that something has been selected which won't be rendered.
  10. Benni Mack updated the commit message in patch set 3 05/25/20, 18:46

  11. TYPO3com voted on patch set 3 V -1 05/25/20, 20:00 Completed build in 1h 11m 29s on Mon, 25 May, 08:00 PM Test Summary: 1 of 74292 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3540

  12. Georg Ringer rebased onto patch set 4 09/10/20, 19:19

  13. TYPO3com voted on patch set 4 V +1 09/10/20, 19:31 Completed build in 11m 03s on Thu, 10 Sep, 07:31 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5516

  14. Georg Ringer uploaded patch set 5 09/17/20, 18:59

  15. TYPO3com voted on patch set 5 V +1 09/17/20, 19:13 Completed build in 13m 40s on Thu, 17 Sep, 07:13 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5694

  16. Oli Bartsch commented on patch set 5 V +1 CR -1 09/22/20, 16:34

    Feature-87982-LanguageOverlayForRecordsInInsertRecordElement.rst:16 Unresolved

    "added to tt_content" or "added to the content element"

    RecordsContentObject.php:99 Unresolved

    Please use stdWrapValue('disableLanguageOverlay', $conf ?? []) to unify as in the rest of the class (see: https://forge.typo3.org/issues/92216)

    tt_content.php:1098 Unresolved

    Let's use 'config' => [ 'type' => 'check', 'renderType' => 'checkboxToggle', 'default' => 1, 'items' => [ [ 0 => '', 1 => '', ] ], ] to unify the UX in the element.
  17. Georg Ringer uploaded patch set 6 09/22/20, 17:57

  18. TYPO3com voted on patch set 6 V -1 09/22/20, 17:57 Completed build in 20s on Tue, 22 Sep, 05:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5826

  19. Oliver Hader commented on patch set 6 CR -1 09/22/20, 18:41

    Is there probably a different way than introducing a new field to control this frontend related behavior? Besides that I'd be in favor in general of using "enable" instead of "disable" to avoid `if (!$disabled)`

    tt_content.php:1110 Unresolved

    isn't something missing here?
  20. Georg Ringer uploaded patch set 7 09/22/20, 19:00

  21. Georg Ringer commented on patch set 7 09/22/20, 19:01

    > Is there probably a different way than introducing a new field to control this frontend related behavior? IMO not as this is a case-by-case issue and content related
  22. TYPO3com voted on patch set 7 V +1 09/22/20, 19:11 Completed build in 11m 16s on Tue, 22 Sep, 07:11 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5827

  23. Markus Klein commented on patch set 7 09/23/20, 06:22

    I'm not sure how this behaves with relations of tt_content. It for sure works flawlessly with pure text elements, but what happens with login form elements and others, which use DB relations. If no overlay is performed then this might cause issues. I know it's tough, but I would definitely see the need to cover this with a lot of functional tests, which ensures correct functionality even for complex tt_content elements being inserted.

    Feature-87982-LanguageOverlayForRecordsInInsertRecordElement.rst:12 Unresolved

    overlaid
  24. Georg Ringer abandoned the change 10/19/21, 19:05

    abandoned, no interest
  25. Sybille Peters commented on patch set 7 07/22/22, 13:05

    What is the reason for this being abandoned? If this should not be pursued, perhaps it is also better to close the related issue with some explanation, e.g. something like either "current behaviour is intended" or "is a bug but will not fix" or something like that and possibly how to deal with older instances which relied on the behaviour being different before. Thanks.