Review main Abandoned

64102[BUGFIX] Fix incorrectly selected items in MM select fields

Sebastian Hofer CR 0 V 0 Easy +4 −4 updated 04/09/20, 13:24

Commit message

In case of MM relation $currentDatabaseValueArray never holds a valid
relation value, because it is everytime the amount of relations. So
it never makes sense to use this value to determine selected items.

That static values do not work, is also described in TYPO3 documentation
of MM TCA option in the note box:
"Using MM relations you can ONLY store real relations for foreign tables
in the list - no additional string values or non-record values."

Solution:
Do not respect $currentDatabaseValueArray as real values in case of MM
relation.

Also done:
Rename $staticValues into $itemArray, because there are no static values
handed over anymore, but the whole item array for this field.
See \TYPO3\CMS\Backend\Form\FormDataProvider\TcaSelectItems line 91

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Sebastian Hofer uploaded patch set 1 04/08/20, 14:40

  2. TYPO3com voted on patch set 1 V +1 04/08/20, 15:02 Completed build in 19m 52s on Wed, 8 Apr, 03:02 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2306

  3. Georg Ringer commented on patch set 1 04/09/20, 13:00

  4. Sebastian Hofer abandoned the change 04/09/20, 13:24

    Another patch will fix this issue.