Review main Merged

64105[BUGFIX] Evaluate proper permissions on pasting content

Oli Bartsch CR +2 V +2 Easy +15 −2 updated 04/20/20, 20:00

Commit message

The check if a user is allowed to paste content from the clipboard
now evaluates the content modify and content edit permissions instead
of the page edit permission. This is done in both PageLayoutView and
the fluid based page module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1922

  1. Oli Bartsch uploaded patch set 1 04/08/20, 20:56

  2. TYPO3com voted on patch set 1 V +1 04/08/20, 21:10 Completed build in 13m 46s on Wed, 8 Apr, 09:10 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2332

  3. Christian Eßl voted on patch set 1 V +1 CR +1 04/17/20, 06:17

  4. Andreas Kienast voted on patch set 1 CR +1 04/17/20, 07:19

  5. Guido Schmechel voted on patch set 1 CR +1 04/17/20, 15:17

  6. Josef Glatz uploaded patch set 2 04/20/20, 09:20

  7. Josef Glatz commented on patch set 2 CR +1 04/20/20, 09:21

    Rebased, please re-vote
  8. Andreas Kienast voted on patch set 2 CR +1 04/20/20, 09:25

  9. Guido Schmechel voted on patch set 2 CR +1 04/20/20, 09:26

  10. Christian Eßl voted on patch set 2 V +1 CR +1 04/20/20, 09:29

  11. Markus Klein commented on patch set 2 CR -1 04/20/20, 09:32

    'editlock' is not checked anymore!
  12. TYPO3com voted on patch set 2 V -1 04/20/20, 09:33 Completed build in 12m 37s on Mon, 20 Apr, 09:33 AM Test Summary: 72 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2876

  13. Oli Bartsch commented on patch set 2 V -1 04/20/20, 09:46

    > Patch Set 2: Code-Review-1 > > 'editlock' is not checked anymore! You are right, on it!
  14. Josef Glatz voted on patch set 2 CR 0 04/20/20, 10:17

  15. Oli Bartsch uploaded patch set 3 04/20/20, 11:21

  16. Oli Bartsch commented on patch set 3 04/20/20, 11:26

    BackendLayoutRenderer.php:269 Unresolved

    I talked to Clause about using GridColumn::isContentEditable. It however should not be used here and furthermore would not work as we have no valid context (regarding SiteLanguage).
  17. Markus Klein voted on patch set 3 CR +1 04/20/20, 11:32

  18. TYPO3com voted on patch set 3 V +1 04/20/20, 11:33 Completed build in 12m 28s on Mon, 20 Apr, 11:33 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2890

  19. Josef Glatz voted on patch set 3 V +1 CR +1 04/20/20, 11:37

  20. Wouter Wolters voted on patch set 3 CR +1 04/20/20, 18:32

  21. Benni Mack voted on patch set 3 V +2 CR +2 04/20/20, 20:00

  22. Benni Mack merged patch set 4 04/20/20, 20:00