Review 9.5 Merged

64107[TASK] Provide test for Page\TreeController

Oliver Hader CR +2 V +2 Hard +595 −9 updated 04/15/20, 08:28

Commit message

Add test for TreeController, so we're safe when refactoring
or doing performance optimizations.

Besides that moved pages in a workspace were not considered when
calculating permissions on the rootline due to missing workspace
overlays.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 67

  1. Oliver Hader uploaded patch set 1 04/09/20, 07:20

  2. TYPO3com voted on patch set 1 V +1 04/09/20, 07:32 Completed build in 12m 17s on Thu, 9 Apr, 07:32 AM Test Summary: 74730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-444

  3. Oliver Hader voted on patch set 1 CR +1 04/09/20, 07:40

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 04/13/20, 13:17

  5. Georg Ringer voted on patch set 1 V +1 CR +1 04/13/20, 17:09

  6. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 04/15/20, 08:28

  7. Tymoteusz Motylewski merged patch set 2 04/15/20, 08:28