64109[BUGFIX] Fix open pageTree status
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2332
Show 47 earlier messages
-
Uwe Trotzek uploaded patch set 1 04/09/20, 10:28
-
TYPO3com voted on patch set 1 V -1 04/09/20, 10:28 Completed build in 23s on Thu, 9 Apr, 10:28 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2343
-
Uwe Trotzek uploaded patch set 2 04/09/20, 10:32
-
Oliver Klee commented on patch set 2 04/09/20, 10:35
BackendUtilityTest.php:21UnresolvedThe tests can have a : void return type declaration.BackendUtilityTest.php:63Unresolved: BackendUserAuthentication -
TYPO3com voted on patch set 2 V +1 04/09/20, 10:51 Completed build in 18m 40s on Thu, 9 Apr, 10:51 AM Test Summary: 73375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2345
-
Uwe Trotzek uploaded patch set 3 04/09/20, 10:53
-
TYPO3com voted on patch set 3 V -1 04/09/20, 11:24 Completed build in 31m 33s on Thu, 9 Apr, 11:24 AM Test Summary: 8 of 73859 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2346
-
Uwe Trotzek commented on patch set 3 04/09/20, 11:49
> Patch Set 3: Verified-1 > > Completed build in 31m 33s on Thu, 9 Apr, 11:24 AM > Test Summary: 8 of 73859 failed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2346 Unfortunately I don't know how to fix this. :-/ Don't know why the other tests are failing suddenly (last change was only typehints and strict declaration in the BackendUtilityTest). The pipeline was green before that. ¯\_(ツ)_/¯ -
Björn Jacob commented on patch set 3 04/11/20, 06:36
A nitpick. Regarding to the contribution guide please start with a capital letter "Fix open...". And please put the Change-Id as the last element behind "Releases...". Thx :) -
Anja Leichsenring updated the commit message in patch set 4 04/12/20, 10:47
-
TYPO3com voted on patch set 4 V +1 04/12/20, 11:04 Completed build in 13m 42s on Sun, 12 Apr, 11:04 AM Test Summary: 73403 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2394
-
Benni Mack commented on patch set 4 04/14/20, 15:12
Does this also apply to 9.5? -
Uwe Trotzek commented on patch set 4 04/16/20, 09:55
> Patch Set 4: > > Does this also apply to 9.5? I'd like to test it under 9.5 but currently I'm not sure how I can trigger this function to be able to test it properly: https://github.com/TYPO3/TYPO3.CMS/blob/0346f6aa2f2b19c0b916666b211b65a9e627dad1/typo3/sysext/backend/Classes/Controller/BackendController.php#L393 Do you know how I can trigger this within the backend? I tested this in master with my other patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/64108 which I'd have to backport first. But this would be quite unnecessary work for me. :) -
Uwe Trotzek commented on patch set 4 04/20/20, 09:17
> Patch Set 4: > > > Patch Set 4: > > > > Does this also apply to 9.5? > > I'd like to test it under 9.5 but currently I'm not sure how I can trigger this function to be able to test it properly: > https://github.com/TYPO3/TYPO3.CMS/blob/0346f6aa2f2b19c0b916666b211b65a9e627dad1/typo3/sysext/backend/Classes/Controller/BackendController.php#L393 > > Do you know how I can trigger this within the backend? > > I tested this in master with my other patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/64108 which I'd have to backport first. But this would be quite unnecessary work for me. :) Okay, I checked this now. The BackendUtility::openPageTree method is broken under TYPO3 9.5 as well. I don't know where this method is actually used in the backend and how I can trigger this via the UI. I built a custom button to check this manually. -
Benni Mack voted on patch set 4 CR +1 04/28/20, 07:41
-
Benni Mack updated the commit message in patch set 5 05/25/20, 18:48
-
TYPO3com voted on patch set 5 V -1 08/11/20, 08:34 Completed build in 28s on Tue, 11 Aug, 08:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4563
-
Oliver Klee wrote 08/11/20, 11:55
Removed reviewer Oliver Klee. -
Christian Kuhn wrote 10/15/20, 11:53
Topic set to workspaces -
Benni Mack rebased onto patch set 6 02/01/21, 21:16
-
TYPO3com commented on patch set 6 02/01/21, 21:17 Completed build in 22s on Mon, 1 Feb, 09:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9179
-
Richard Haeser uploaded patch set 7 02/09/21, 14:08
-
TYPO3com voted on patch set 7 V +1 02/09/21, 14:17 Completed build in 09m 04s on Tue, 9 Feb, 02:17 PM Test Summary: 32603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9397
-
core-ci voted on patch set 7 V +1 02/09/21, 14:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/535
-
Benni Mack commented on patch set 7 04/19/21, 18:44
we need both, @Uwe - the existing state was used for all trees except the SVG tree (in v10), however for v11 this patch would be OK as is. -
Benni Mack voted on patch set 7 CR +1 04/26/21, 17:25
-
Christian Kuhn rebased onto patch set 8 04/27/21, 18:24
-
Christian Kuhn commented on patch set 8 04/27/21, 18:34
maybe change in master only, then? -
core-ci voted on patch set 8 V +1 04/27/21, 18:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10760
-
Christian Kuhn commented on patch set 8 V +1 CR +1 04/27/21, 18:50
ok, fine with me. -
Benni Mack voted on patch set 8 V +2 CR +2 04/27/21, 18:51
-
Benni Mack merged patch set 9 04/27/21, 18:51
BackendUtilityTest.php:3Unresolved