Review main Abandoned

64112[BUGFIX] Fetch records of MM table by translated record

Stefan Froemken CR 0 V 0 Normal +209 −20 updated 12/05/23, 08:51

Commit message

Most relation columns in TYPO3 contains the UID of the
foreign record in default language. e.g., a translated
tt_content record contains the UID of the page record
in the default language.
But in case of a MM table with uid_local and uid_foreign,
each translated record has its own relation in this table.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 2843

Show 1218 earlier messages
  1. Stefan Froemken uploaded patch set 1 04/09/20, 17:06

  2. Stefan Froemken commented on patch set 1 04/09/20, 17:11

    TranslationTest.php:546

    Currently getPosts returns 6 Posts in various languages
  3. Stefan Froemken commented on patch set 1 04/09/20, 17:13

    TranslationTest.php:566

    Currently this results 0
  4. TYPO3com voted on patch set 1 V -1 04/09/20, 17:24 Completed build in 17m 29s on Thu, 9 Apr, 05:24 PM Test Summary: 18 of 73865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2358

  5. Stefan Froemken uploaded patch set 2 04/09/20, 17:31

  6. TYPO3com voted on patch set 2 V -1 04/09/20, 17:31 Completed build in 22s on Thu, 9 Apr, 05:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2359

  7. Stefan Froemken uploaded patch set 3 04/09/20, 17:38

  8. TYPO3com voted on patch set 3 V -1 04/09/20, 17:39 Completed build in 43s on Thu, 9 Apr, 05:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2362

  9. Stefan Froemken uploaded patch set 4 04/09/20, 23:07

  10. TYPO3com voted on patch set 4 V -1 04/09/20, 23:20 Completed build in 12m 25s on Thu, 9 Apr, 11:20 PM Test Summary: 15 of 73865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2366

  11. Benni Mack commented on patch set 4 04/11/20, 13:34

    Hey Stefan, what would happen on the following scenarios: a) A translated news pointing to a e.g. category "Football", which is LATER translated into "Fußball"? Would this be considered? b) A translated news pointing to a non-translateable table - e.g. "tag"? Would this work? I guess so.
  12. Oliver Klee updated the commit message in patch set 5 04/11/20, 14:01

  13. TYPO3com voted on patch set 5 V -1 04/11/20, 14:12 Completed build in 11m 18s on Sat, 11 Apr, 02:12 PM Test Summary: 15 of 73865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2376

  14. Alexander Schnitzler wrote 04/12/20, 10:53

    Topic set to extbase
  15. Stefan Froemken commented on patch set 5 04/14/20, 07:10

    > Patch Set 4: > > Hey Stefan, > > what would happen on the following scenarios: > a) A translated news pointing to a e.g. category "Football", which is LATER translated into "Fußball"? Would this be considered? > b) A translated news pointing to a non-translateable table - e.g. "tag"? Would this work? I guess so. Hello Benni: It will not work with Categories and I don't know, if it will work with sys_file_reference, but possibly not. It currently works for MM tables, only. MM tables which are registered in TCA as "MM". sys_file_reference and sy_category_record_mm are not registered as "MM", but they have uid_foreign and uid_local and they are related to each translated record's UID. I need an indicator for each intermediate table to know, if it contains the translated UIDs or the UIDs of records in default language. And remember: in case of IRRE we have relations to the translated record's UIDs, but if you activate "useCombination", we may have to use the UID of record in default language. Maybe it would be good to extend ColumnMap with these additional information to get this problem solved.

    DataMapper.php:435

    For default language this results in fetching all releated records of sub-property, regardless of its language. In case of translated record, the sub-property is empty.

    Typo3DbQueryParser.php:567

    In TYPO3 all translated relations were realized by the UID of the record in default language. Please have a look into an translated tt_content record. Their PID is the UID of the page in default language. So please, never work with the UID of translated records here.
  16. Stefan Froemken updated the commit message in patch set 6 04/14/20, 07:11

  17. TYPO3com voted on patch set 6 V -1 04/14/20, 07:25 Completed build in 13m 56s on Tue, 14 Apr, 07:25 AM Test Summary: 15 of 73953 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2476

  18. Benni Mack uploaded patch set 7 04/30/21, 17:10

  1. core-ci voted on patch set 7 V -1 04/30/21, 17:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10978

  2. Benni Mack uploaded patch set 8 05/01/21, 12:13

  3. Benni Mack commented on patch set 8 05/01/21, 12:15

    Hey Stefan, the tests show that the IRRE elements of blog posts are not resolved anymore. This is due to the fact that a IRRE child (in this case sys_file_reference) has a parent pointing to the localized version of the post itself, which is now not resolved anymore (because you check for MM relations). The sys_file_reference resolving (= child elements when doing a simple findAll()) does not take the "_localizedUid" anymore for parent records resolving.
  4. core-ci voted on patch set 8 V -1 05/01/21, 12:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11007

  5. Benni Mack updated the commit message in patch set 9 11/18/21, 10:37

  6. core-ci voted on patch set 9 V -1 11/18/21, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19448

  7. Benni Mack wrote 11/29/21, 10:15

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 10 11/29/21, 14:02

  9. core-ci voted on patch set 10 V -1 11/29/21, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20078

  10. Alexander Schnitzler wrote 11/30/21, 13:58

    Removed reviewer Alexander Schnitzler.
  11. Benni Mack uploaded patch set 11 12/01/21, 22:06

  12. core-ci voted on patch set 11 V -1 12/01/21, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20370

  13. Stefan Froemken uploaded patch set 12 12/24/21, 02:58

  14. core-ci voted on patch set 12 V -1 12/24/21, 03:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21453

  15. Stefan Froemken uploaded patch set 13 12/24/21, 13:32

  16. Stefan Froemken commented on patch set 13 12/24/21, 13:33

    Rebased
  17. Stefan Froemken commented on patch set 13 12/24/21, 13:34

    TranslationTest.php:546 Reply

    Done

    TranslationTest.php:566 Reply

    Done
  18. Stefan Froemken commented on patch set 13 12/24/21, 13:34

    DataMapper.php:435 Reply

    Done

    Typo3DbQueryParser.php:567 Reply

    Done
  19. core-ci voted on patch set 13 V -1 12/24/21, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21456

  20. Stefan Froemken uploaded patch set 14 12/24/21, 14:47

  21. Stefan Froemken commented on patch set 14 V -1 12/24/21, 14:51

    Problem is: I need the ColumnMap of "category" column of Blog to get the used relation, but currently I only get the ColumnMap of the column of the related table like sys_category_record_mm:uid_foreign. But for such columns we don't have a ColumnMap or a false ColumnMap. This patch has to be completely reworked. Damn.
  22. core-ci voted on patch set 14 V -1 12/24/21, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21457

  23. Benni Mack updated the commit message in patch set 15 V -1 05/03/23, 09:13

  24. core-ci voted on patch set 15 V -1 05/03/23, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41382

  25. Benni Mack abandoned the change 12/05/23, 08:51

    will abandon this for the time being, can be restored later.