Review main Merged

64117[BUGFIX] Do not default to type="text/javascript" in AssetRenderer

Jonas Eberle CR +2 V +2 Normal +52 −25 updated 04/12/20, 05:04

Commit message

This omits type="text/javascript" by default for JavaScript assets.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Riccardo De Contardi +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 911

  1. Jonas Eberle uploaded patch set 1 04/11/20, 14:46

  2. TYPO3com voted on patch set 1 V +1 04/11/20, 14:57 Completed build in 11m 38s on Sat, 11 Apr, 02:57 PM Test Summary: 73393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2377

  3. Riccardo De Contardi commented on patch set 1 V +1 04/11/20, 16:06

    Code works, now it is just needed an example on documentation about how to add the attribute if needed again :)
  4. Oliver Klee voted on patch set 1 CR +1 04/11/20, 17:08

  5. Jonas Eberle commented on patch set 1 04/11/20, 18:03

    > Patch Set 1: Verified+1 > > Code works, now it is just needed an example on documentation about how to add the attribute if needed again :) Good point. I'll update the AssetCollector Changelog with an example.
  6. Jonas Eberle uploaded patch set 2 04/11/20, 18:07

  7. TYPO3com voted on patch set 2 V +1 04/11/20, 18:19 Completed build in 11m 29s on Sat, 11 Apr, 06:18 PM Test Summary: 73392 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2378

  8. Riccardo De Contardi commented on patch set 2 V +1 04/11/20, 20:32

    Works fine; tried also with `<f:asset.script identifier="identifier123" src="fileadmin/test.js" type="text/javascript" />` and worked great.
  9. Benni Mack commented on patch set 2 V +1 CR +1 04/11/20, 22:11

    Great. This ensures the same behaviour as without the AssetRenderer.
  10. Andreas Kienast voted on patch set 2 V +2 CR +2 04/12/20, 05:04

  11. Andreas Kienast merged patch set 3 04/12/20, 05:04