Review main Merged

64118[TASK] Deprecate various hooks related to TypoScriptFrontendController

Benni Mack CR +2 V +2 Hard +197 −94 updated 04/14/20, 06:44

Commit message

PSR-15 and Request/Response handling has been proven to be a
worthy replacement for most logic related for outputting content
in the TYPO3 Frontend.

In order to thin out TSFE in future TYPO3 versions, various hooks have
been deprecated as they can also be used with proper PSR-15 middlewares.

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-contentStrReplace']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-output']

The following methods are marked as deprecated as well:
* $TSFE->isOutputting()
* $TSFE->processContentForOutput()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1421

  1. Benni Mack uploaded patch set 1 04/11/20, 22:04

  2. TYPO3com voted on patch set 1 V +1 04/11/20, 22:16 Completed build in 11m 59s on Sat, 11 Apr, 10:16 PM Test Summary: 73369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2383

  3. Benni Mack uploaded patch set 2 04/13/20, 10:51

  4. TYPO3com voted on patch set 2 V +1 04/13/20, 11:22 Completed build in 24m 34s on Mon, 13 Apr, 11:22 AM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2437

  5. Benni Mack uploaded patch set 3 04/13/20, 21:21

  6. TYPO3com voted on patch set 3 V +1 04/13/20, 21:32 Completed build in 11m 18s on Mon, 13 Apr, 09:32 PM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2461

  7. Georg Ringer voted on patch set 3 V +1 CR +1 04/14/20, 04:52

  8. Josef Glatz rebased onto patch set 4 04/14/20, 05:00

  9. Josef Glatz uploaded patch set 5 04/14/20, 05:00

  10. TYPO3com voted on patch set 4 V +1 04/14/20, 05:12 Completed build in 11m 49s on Tue, 14 Apr, 05:11 AM Test Summary: 73456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2464

  11. Josef Glatz voted on patch set 5 V +1 CR +1 04/14/20, 05:13

  12. Josef Glatz voted on patch set 5 V -1 CR -1 04/14/20, 05:15

  13. Josef Glatz commented on patch set 5 04/14/20, 05:15

    will fix some typos in next patch set
  14. TYPO3com voted on patch set 5 V -1 04/14/20, 05:19 Completed build in 17m 40s on Tue, 14 Apr, 05:19 AM Test Summary: 1 of 73942 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2465

  15. Josef Glatz uploaded patch set 6 04/14/20, 05:26

  16. Georg Ringer voted on patch set 6 V +1 CR +1 04/14/20, 05:33

  17. TYPO3com voted on patch set 6 V -1 04/14/20, 06:02 Completed build in 35m 06s on Tue, 14 Apr, 06:02 AM Test Summary: 5 of 73301 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2466

  18. Josef Glatz voted on patch set 6 V +1 CR +1 04/14/20, 06:03

  19. TYPO3com voted on patch set 6 V +1 04/14/20, 06:33 Completed build in 15m 12s on Tue, 14 Apr, 06:33 AM Test Summary: 73456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2470

  20. Benni Mack voted on patch set 6 V +2 CR +2 04/14/20, 06:44

  21. Benni Mack merged patch set 7 04/14/20, 06:44