Review main Merged

64121[BUGFIX] Restore ckeditor selections when unloading modal

Andreas Kienast CR +2 V +2 Easy +6 −2 updated 04/12/20, 19:57

Commit message

Navigating in the RteLinkBrowser by e.g. switching tabs or browsing the
file tree now recovers the selections of the underlying ckeditor. This
allows to invoke a browser search, navigate within the link browser and
place a link afterwards.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 911

  1. Andreas Kienast uploaded patch set 1 04/12/20, 06:14

  2. Andreas Kienast commented on patch set 1 04/12/20, 06:20

  3. TYPO3com voted on patch set 1 V -1 04/12/20, 06:25 Completed build in 11m 08s on Sun, 12 Apr, 06:25 AM Test Summary: 61774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2387

  4. TYPO3com voted on patch set 1 V +1 04/12/20, 06:34 Completed build in 30m 50s on Sun, 12 Apr, 06:34 AM Test Summary: 73463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2387

  5. Anja Leichsenring commented on patch set 1 04/12/20, 10:23

    sorry I don't get it. What ranges get lost, and how is the behavior different with this patch? Could you give an example? Thanks.
  6. Anja Leichsenring commented on patch set 1 04/12/20, 11:14

    > Patch Set 1: > > sorry I don't get it. What ranges get lost, and how is the behavior different with this patch? Could you give an example? Thanks. so how to reproduce: - have browser console open - mark a word / some words in a RTE field - open link browser - open Tab File - go to any folder - invoke a browser search (STRG+F) - open Tab Email in the link browser - go back to tab File - find your former place again - insert your search (by click) => browser console reports error Cannot read property 'getParent' of null and modale is not closed.
  7. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/12/20, 11:15

  8. Josef Glatz voted on patch set 1 V +1 CR +1 04/12/20, 19:11

  9. Josef Glatz commented on patch set 1 04/12/20, 19:12

    nice followup Mr. Fernandez
  10. Benni Mack voted on patch set 1 V +2 CR +2 04/12/20, 19:57

  11. Benni Mack merged patch set 2 04/12/20, 19:57