64121[BUGFIX] Restore ckeditor selections when unloading modal
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 911
-
Andreas Kienast uploaded patch set 1 04/12/20, 06:14
-
Andreas Kienast commented on patch set 1 04/12/20, 06:20
Backport: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64122 -
TYPO3com voted on patch set 1 V -1 04/12/20, 06:25 Completed build in 11m 08s on Sun, 12 Apr, 06:25 AM Test Summary: 61774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2387
-
TYPO3com voted on patch set 1 V +1 04/12/20, 06:34 Completed build in 30m 50s on Sun, 12 Apr, 06:34 AM Test Summary: 73463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2387
-
Anja Leichsenring commented on patch set 1 04/12/20, 10:23
sorry I don't get it. What ranges get lost, and how is the behavior different with this patch? Could you give an example? Thanks. -
Anja Leichsenring commented on patch set 1 04/12/20, 11:14
> Patch Set 1: > > sorry I don't get it. What ranges get lost, and how is the behavior different with this patch? Could you give an example? Thanks. so how to reproduce: - have browser console open - mark a word / some words in a RTE field - open link browser - open Tab File - go to any folder - invoke a browser search (STRG+F) - open Tab Email in the link browser - go back to tab File - find your former place again - insert your search (by click) => browser console reports error Cannot read property 'getParent' of null and modale is not closed. -
Anja Leichsenring voted on patch set 1 V +1 CR +1 04/12/20, 11:15
-
Josef Glatz voted on patch set 1 V +1 CR +1 04/12/20, 19:11
-
Josef Glatz commented on patch set 1 04/12/20, 19:12
nice followup Mr. Fernandez -
Benni Mack voted on patch set 1 V +2 CR +2 04/12/20, 19:57
-
Benni Mack merged patch set 2 04/12/20, 19:57