Review main Merged

64124[BUGFIX] Force typecast to string in ArrayBrowser

Georg Ringer CR +2 V +2 Easy +4 −4 updated 04/12/20, 22:01

Commit message

Make sure that the key in ArrayBrowser::getSearchKeys() is always cast
to string.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Georg Ringer uploaded patch set 1 04/12/20, 19:06

  2. Georg Ringer commented on patch set 1 04/12/20, 19:06

    This change is ready for review.
  3. Benni Mack voted on patch set 1 V +1 CR +1 04/12/20, 19:10

  4. TYPO3com voted on patch set 1 V +1 04/12/20, 19:17 Completed build in 11m 19s on Sun, 12 Apr, 07:17 PM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2402

  5. Jonas Eberle voted on patch set 1 V +1 CR +1 04/12/20, 19:37

  6. Christian Eßl commented on patch set 1 V -1 04/12/20, 20:21

    still broken in regex mode
  7. Christian Eßl uploaded patch set 2 04/12/20, 20:24

  8. Christian Eßl updated the commit message in patch set 3 04/12/20, 20:26

  9. Christian Eßl voted on patch set 3 V +1 CR +1 04/12/20, 20:26

  10. TYPO3com voted on patch set 2 V +1 04/12/20, 20:35 Completed build in 11m 07s on Sun, 12 Apr, 08:35 PM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2410

  11. TYPO3com voted on patch set 3 V +1 04/12/20, 20:40 Completed build in 14m 23s on Sun, 12 Apr, 08:40 PM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2411

  12. Jonas Eberle voted on patch set 3 V +1 CR +1 04/12/20, 21:05

  13. Benni Mack voted on patch set 3 V +2 CR +2 04/12/20, 22:01

  14. Benni Mack merged patch set 4 04/12/20, 22:01