Review main Merged

64125[BUGFIX] Show "All" language flag again in Page module (old and Fluid)

Jonas Eberle CR +2 V +2 Easy +10 −9 updated 08/12/20, 07:20

Commit message

Due to the logic being based around SiteLanguages and the "All" language
not being one, it was excluded from being rendered in the content header.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1623

  1. Jonas Eberle uploaded patch set 1 04/12/20, 23:03

  2. TYPO3com voted on patch set 1 V -1 04/12/20, 23:05 Completed build in 02m 04s on Sun, 12 Apr, 11:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2416

  3. TYPO3com commented on patch set 1 04/12/20, 23:11 Completed build in 02m 04s on Sun, 12 Apr, 11:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2417

  4. Jonas Eberle uploaded patch set 2 04/12/20, 23:16

  5. TYPO3com voted on patch set 2 V -1 04/12/20, 23:18 Completed build in 02m 04s on Sun, 12 Apr, 11:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2418

  6. TYPO3com commented on patch set 2 04/14/20, 06:24 Completed build in 32m 22s on Tue, 14 Apr, 06:24 AM Test Summary: 3 of 73942 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2468

  7. TYPO3com voted on patch set 2 V +1 04/14/20, 06:38 Completed build in 1h 18m 12s on Tue, 14 Apr, 06:38 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2468

  8. Benni Mack uploaded patch set 3 04/20/20, 13:40

  9. TYPO3com voted on patch set 3 V +1 04/20/20, 13:54 Completed build in 13m 29s on Mon, 20 Apr, 01:54 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2896

  10. Susi Moog commented on patch set 3 V -1 04/20/20, 14:14

    duplicates default lang in column view.
  11. Jonas Eberle commented on patch set 3 04/20/20, 14:23

    > Patch Set 3: Verified-1 > > duplicates default lang in column view. Are you in Fluid page module? It's a known problem there. This only outputs icons.
  12. Jonas Eberle commented on patch set 3 04/20/20, 14:25

    I stay corrected. I didn't see the last patchset... That escalated quickly!?
  13. Helmut Hummel voted on patch set 3 CR +1 05/05/20, 14:54

  14. Claus Due commented on patch set 3 05/06/20, 09:56

    Overall looks fine, just that one question about the return value (if we can avoid an additional special condition case that would be preferable).

    PageLayoutContext.php:217

    Will $this->site->getLanguageById(-1) return the wrong value?
  15. Benni Mack updated the commit message in patch set 4 05/25/20, 18:50

  16. Benni Mack commented on patch set 4 08/07/20, 15:49

    PageLayoutContext.php:217 Reply Unresolved

    Yes. this won't work.
  17. Benni Mack rebased onto patch set 5 08/07/20, 15:49

  18. Benni Mack voted on patch set 5 CR +1 08/07/20, 15:49

  19. TYPO3com voted on patch set 5 V +1 08/07/20, 16:06 Completed build in 16m 45s on Fri, 7 Aug, 04:06 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4488

  20. Daniel Haupt voted on patch set 5 V +1 CR +1 08/09/20, 00:29

  21. Benni Mack voted on patch set 5 V +2 CR +2 08/10/20, 14:04

  22. Benni Mack merged patch set 6 08/10/20, 14:04

  23. Georg Ringer commented on patch set 6 08/12/20, 07:20

    post review -1, now default language is shown twice, see https://forge.typo3.org/issues/91986