Review main Merged

64127[TASK] Require php-webdriver/webdriver for development purposes

Anja Leichsenring CR +2 V +2 Hard +16 −456 updated 04/16/20, 06:52

Commit message

command:
composer require --dev php-webdriver/webdriver:^1.8

This version of webdriver contains the newly recommended
UnknownErrorException, that replaces the deprecated
UnknownServerExecption
we used before.

command:
composer require --dev codeception/module-webdriver:^1.0.1

The webdriver package underwent a namechange from "facebook/webdriver"
to "php-webdriver/webdriver". Only "codeception/module-webdriver"
requires this package, so in order to get rid of the old one,
also this dependency needs a raise.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1134

Show 49 earlier messages
  1. Anja Leichsenring uploaded patch set 1 04/13/20, 10:02

  2. TYPO3com voted on patch set 1 V -1 04/13/20, 10:17 Completed build in 15m 14s on Mon, 13 Apr, 10:17 AM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2431

  3. TYPO3com commented on patch set 1 04/13/20, 10:20 Completed build in 12m 23s on Mon, 13 Apr, 10:20 AM Test Summary: 4 of 270 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-20

  4. Anja Leichsenring uploaded patch set 2 04/13/20, 10:43

  5. Anja Leichsenring updated the commit message in patch set 3 04/13/20, 10:47

  6. TYPO3com voted on patch set 2 V +1 04/13/20, 10:58 Completed build in 14m 21s on Mon, 13 Apr, 10:58 AM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2433

  7. TYPO3com voted on patch set 2 V -1 04/13/20, 10:59 Completed build in 13m 15s on Mon, 13 Apr, 10:59 AM Test Summary: 4 of 270 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-21

  8. TYPO3com voted on patch set 3 V +1 04/13/20, 11:11 Completed build in 21m 37s on Mon, 13 Apr, 11:11 AM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2435

  9. Anja Leichsenring uploaded patch set 4 04/13/20, 11:27

  1. TYPO3com voted on patch set 4 V -1 04/13/20, 12:10 Completed build in 42m 36s on Mon, 13 Apr, 12:10 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2439

  2. Anja Leichsenring uploaded patch set 5 04/13/20, 12:13

  3. TYPO3com commented on patch set 4 04/13/20, 12:16 Completed build in 24m 24s on Mon, 13 Apr, 12:16 PM Test Summary: 31 of 273 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-22

  4. TYPO3com voted on patch set 5 V +1 04/13/20, 12:37 Completed build in 17m 31s on Mon, 13 Apr, 12:37 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2441

  5. TYPO3com voted on patch set 5 V -1 04/13/20, 13:06 Completed build in 34m 53s on Mon, 13 Apr, 01:06 PM Test Summary: 20 of 494 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-23

  6. TYPO3com commented on patch set 5 04/13/20, 13:33 Completed build in 1h 36m 01s on Mon, 13 Apr, 01:33 PM Test Summary: 487 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-23

  7. TYPO3com voted on patch set 5 V +1 04/13/20, 14:26 Completed build in 3h 30m 23s on Mon, 13 Apr, 02:26 PM Test Summary: 819 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-23

  8. TYPO3com voted on patch set 5 V -1 04/14/20, 08:46 Completed build in 2h 04m 53s on Tue, 14 Apr, 08:46 AM Test Summary: 1965 of 309078 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-25

  9. TYPO3com commented on patch set 5 04/14/20, 09:35 Completed build in 4h 59m 07s on Tue, 14 Apr, 09:35 AM Test Summary: 312674 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-25

  10. TYPO3com voted on patch set 5 V +1 04/14/20, 09:53 Completed build in 8h 11m 00s on Tue, 14 Apr, 09:53 AM Test Summary: 312849 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-25

  11. Benni Mack updated the commit message in patch set 6 04/14/20, 12:15

  12. Benni Mack updated the commit message in patch set 7 04/14/20, 12:15

  13. TYPO3com voted on patch set 7 V +1 04/14/20, 12:35 Completed build in 16m 09s on Tue, 14 Apr, 12:35 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2497

  14. TYPO3com voted on patch set 6 V +1 04/14/20, 12:39 Completed build in 20m 39s on Tue, 14 Apr, 12:39 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2496

  15. TYPO3com voted on patch set 7 V -1 04/15/20, 08:14 Completed build in 2h 36m 16s on Wed, 15 Apr, 08:14 AM Test Summary: 408 of 307841 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-26

  16. TYPO3com commented on patch set 7 04/15/20, 16:43 Completed build in 13h 40m 46s on Wed, 15 Apr, 04:43 PM Test Summary: 107 of 311557 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-26

  17. TYPO3com commented on patch set 7 04/15/20, 19:06 Completed build in 3h 09m 10s on Wed, 15 Apr, 07:06 PM Test Summary: 3 of 314394 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-26

  18. TYPO3com commented on patch set 7 04/15/20, 19:30 Completed build in 17h 00m 39s on Wed, 15 Apr, 07:29 PM Test Summary: 312601 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-26

  19. TYPO3com voted on patch set 7 V +1 04/15/20, 20:14 Completed build in 7h 36m 15s on Wed, 15 Apr, 08:14 PM Test Summary: 313114 passed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-26

  20. Anja Leichsenring uploaded patch set 8 04/16/20, 05:51

  21. TYPO3com voted on patch set 8 V -1 04/16/20, 06:03 Completed build in 12m 03s on Thu, 16 Apr, 06:03 AM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2623

  22. Anja Leichsenring uploaded patch set 9 04/16/20, 06:22

  23. TYPO3com voted on patch set 9 V +1 04/16/20, 06:35 Completed build in 12m 59s on Thu, 16 Apr, 06:35 AM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2628

  24. Benni Mack voted on patch set 9 V +2 CR +2 04/16/20, 06:52

  25. Benni Mack merged patch set 10 04/16/20, 06:52