Review main Merged

64129[TASK] Auto focus search field in "New Content Element" filter

Andreas Kienast CR +2 V +2 Easy +17 −3 updated 04/14/20, 14:28

Commit message

To improve the user experience, the search filter in the "New Content
Element" wizard is automatically focussed when the modal appears.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1012

  1. Andreas Kienast uploaded patch set 1 04/13/20, 14:01

  2. TYPO3com voted on patch set 1 V +1 04/13/20, 14:20 Completed build in 15m 46s on Mon, 13 Apr, 02:20 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2448

  3. Josef Glatz commented on patch set 1 V -1 04/14/20, 08:58

    ❌ Unfortunately does not work in my first test run with Google Chrome (Version 80.0.3987.163 (Offizieller Build) (64-Bit), macOS). (tried to delete whole browser cache; also in inkognito Mode)
  4. Andreas Kienast commented on patch set 1 04/14/20, 09:34

    > Patch Set 1: Verified-1 > > ❌ Unfortunately does not work in my first test run with Google Chrome (Version 80.0.3987.163 (Offizieller Build) (64-Bit), macOS). (tried to delete whole browser cache; also in inkognito Mode) I fail to reproduce your reported misbehavior. Let's have a call at 14:45 to elaborate on the issue if you're fine.
  5. Josef Glatz commented on patch set 1 04/14/20, 09:50

    > Patch Set 1: > > > Patch Set 1: Verified-1 > > > > ❌ Unfortunately does not work in my first test run with Google Chrome (Version 80.0.3987.163 (Offizieller Build) (64-Bit), macOS). (tried to delete whole browser cache; also in inkognito Mode) > > I fail to reproduce your reported misbehavior. Let's have a call at 14:45 to elaborate on the issue if you're fine. KK, 14:45, check check
  6. Andreas Kienast commented on patch set 1 V -1 04/14/20, 12:59

    Can reproduce with slow network
  7. Josef Glatz commented on patch set 1 04/14/20, 13:05

    > Patch Set 1: Verified-1 > > Can reproduce with slow network or just use a slow computer^^
  8. Andreas Kienast uploaded patch set 2 04/14/20, 13:31

  9. TYPO3com voted on patch set 2 V +1 04/14/20, 13:43 Completed build in 11m 49s on Tue, 14 Apr, 01:43 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2503

  10. Josef Glatz commented on patch set 2 V +1 CR +1 04/14/20, 14:26

    verified on a slow MACuter™ (Chrome, Firefox, Safari) each of them latest, stable
  11. Benni Mack voted on patch set 2 V +2 CR +2 04/14/20, 14:28

  12. Benni Mack merged patch set 3 04/14/20, 14:28