Review main Merged

64130[TASK] Reduce inline JavaScript in ext:beuser

Oliver Hader CR +2 V +2 Normal +164 −27 updated 04/20/20, 09:09

Commit message

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings. There are still a couple of aspects
that need to be solved in a general way - e.g. assigning global
language labels (`TYPO3.lang`) or settings (`TYPO3.settings`).

* extracts inline JavaScript from controllers & templates
* GlobalEventHandler is extended to deal with custom scenarios
  that acutally would trigger a browser navigate events (e.g.
  changing a select drop-down leads to a document refresh)
* ActionDispatcher is introduced to listen and delegate
  events to global TYPO3 modules in `top` window scope

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 2739

Show 914 earlier messages
  1. Oliver Hader uploaded patch set 1 04/13/20, 16:25

  2. TYPO3com voted on patch set 1 V -1 04/13/20, 16:36 Completed build in 11m 20s on Mon, 13 Apr, 04:36 PM Test Summary: 73408 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2451

  3. Oliver Hader uploaded patch set 2 04/13/20, 16:38

  4. TYPO3com voted on patch set 2 V +1 04/13/20, 16:50 Completed build in 11m 21s on Mon, 13 Apr, 04:50 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2452

  5. Oliver Hader uploaded patch set 3 04/13/20, 17:33

  6. Oliver Hader marked it work in progress 04/13/20, 17:36

  7. TYPO3com voted on patch set 3 V -1 04/13/20, 17:46 Completed build in 12m 21s on Mon, 13 Apr, 05:46 PM Test Summary: 73439 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2455

  8. Oliver Hader uploaded patch set 4 04/15/20, 16:33

  9. Oliver Hader commented on patch set 4 04/15/20, 16:33

    This change is ready for review.
  10. TYPO3com voted on patch set 4 V +1 04/15/20, 16:52 Completed build in 14m 04s on Wed, 15 Apr, 04:52 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2596

  11. Oliver Hader commented on patch set 4 CR -1 04/16/20, 16:07

  12. Oliver Hader uploaded patch set 5 04/16/20, 17:11

  13. TYPO3com voted on patch set 5 V -1 04/16/20, 17:11 Completed build in 20s on Thu, 16 Apr, 05:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2660

  14. Oliver Hader commented on patch set 5 04/16/20, 17:14

    Great... it's not possible to stack commits for Bamboo testing...
  1. Oliver Hader rebased onto patch set 6 04/16/20, 20:19

  2. TYPO3com voted on patch set 6 V +1 04/16/20, 20:30 Completed build in 11m 11s on Thu, 16 Apr, 08:30 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2662

  3. Benni Mack commented on patch set 6 04/16/20, 21:09

    PermissionController.php:134

    do we really need this line?
  4. Oliver Hader commented on patch set 6 04/17/20, 06:02

    PermissionController.php:134 Reply Unresolved

    Probably not, now that it's available in ModuleTemplate...
  5. Oliver Hader uploaded patch set 7 04/17/20, 06:02

  6. TYPO3com voted on patch set 7 V +1 04/17/20, 06:15 Completed build in 13m 21s on Fri, 17 Apr, 06:15 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2682

  7. Oliver Hader voted on patch set 7 CR -1 04/17/20, 11:18

  8. Oliver Hader uploaded patch set 8 04/18/20, 12:32

  9. Oliver Hader wrote 04/18/20, 12:35

    Topic set to inline-javascript
  10. TYPO3com voted on patch set 8 V +1 04/18/20, 12:59 Completed build in 21m 10s on Sat, 18 Apr, 12:59 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2792

  11. Oliver Hader uploaded patch set 9 04/18/20, 21:02

  12. TYPO3com voted on patch set 9 V -1 04/18/20, 21:03 Completed build in 19s on Sat, 18 Apr, 09:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2824

  13. Oliver Hader commented on patch set 9 04/18/20, 21:05

  14. Oliver Hader uploaded patch set 10 04/19/20, 10:01

  15. TYPO3com voted on patch set 10 V -1 04/19/20, 10:02 Completed build in 20s on Sun, 19 Apr, 10:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2834

  16. Oliver Hader uploaded patch set 11 04/19/20, 10:06

  17. TYPO3com voted on patch set 11 V -1 04/19/20, 10:07 Completed build in 20s on Sun, 19 Apr, 10:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2835

  18. Oliver Hader voted on patch set 11 CR -1 04/19/20, 10:14

  19. Oliver Hader uploaded patch set 12 04/19/20, 10:18

  20. TYPO3com voted on patch set 12 V +1 04/19/20, 10:30 Completed build in 11m 52s on Sun, 19 Apr, 10:30 AM Test Summary: 73652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2836

  21. Benni Mack voted on patch set 12 V +1 CR +1 04/19/20, 19:52

  22. Andreas Kienast commented on patch set 12 V +1 04/20/20, 06:07

    ActionDispatcher.ts:55 Unresolved

    This method is unused. Is it obsolete or do we need it later™?
  23. Josef Glatz commented on patch set 12 V +1 CR +1 04/20/20, 09:08

    * VERIFIED: Tested each part functionally in different browsers under macOS. ✅
  24. Benni Mack voted on patch set 12 V +2 CR +2 04/20/20, 09:09

  25. Benni Mack merged patch set 13 04/20/20, 09:09