64130[TASK] Reduce inline JavaScript in ext:beuser
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ActionDispatcher.ts1new+94 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/GlobalEventHandler.ts+12 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/InfoWindow.ts+4 −0
- Build/Sources/TypeScript/beuser/Resources/Public/TypeScript/Permissions.ts+8 −1
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ActionDispatcher.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/GlobalEventHandler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/InfoWindow.js+1 −1
- typo3/sysext/beuser/Classes/Controller/PermissionController.php2+1 −1
- typo3/sysext/beuser/Resources/Private/Layouts/Default.html+3 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+3 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/IndexListRow.html+3 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html+15 −15
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+2 −2
- typo3/sysext/beuser/Resources/Public/JavaScript/Permissions.js+1 −1
Review log 2739
Show 914 earlier messages
-
Oliver Hader uploaded patch set 1 04/13/20, 16:25
-
TYPO3com voted on patch set 1 V -1 04/13/20, 16:36 Completed build in 11m 20s on Mon, 13 Apr, 04:36 PM Test Summary: 73408 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2451
-
Oliver Hader uploaded patch set 2 04/13/20, 16:38
-
TYPO3com voted on patch set 2 V +1 04/13/20, 16:50 Completed build in 11m 21s on Mon, 13 Apr, 04:50 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2452
-
Oliver Hader uploaded patch set 3 04/13/20, 17:33
-
Oliver Hader marked it work in progress 04/13/20, 17:36
-
TYPO3com voted on patch set 3 V -1 04/13/20, 17:46 Completed build in 12m 21s on Mon, 13 Apr, 05:46 PM Test Summary: 73439 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2455
-
Oliver Hader uploaded patch set 4 04/15/20, 16:33
-
Oliver Hader commented on patch set 4 04/15/20, 16:33
This change is ready for review. -
TYPO3com voted on patch set 4 V +1 04/15/20, 16:52 Completed build in 14m 04s on Wed, 15 Apr, 04:52 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2596
-
Oliver Hader commented on patch set 4 CR -1 04/16/20, 16:07
Maybe things can simplified with https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 -
Oliver Hader uploaded patch set 5 04/16/20, 17:11
-
TYPO3com voted on patch set 5 V -1 04/16/20, 17:11 Completed build in 20s on Thu, 16 Apr, 05:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2660
-
Oliver Hader commented on patch set 5 04/16/20, 17:14
Great... it's not possible to stack commits for Bamboo testing...
-
Oliver Hader rebased onto patch set 6 04/16/20, 20:19
-
TYPO3com voted on patch set 6 V +1 04/16/20, 20:30 Completed build in 11m 11s on Thu, 16 Apr, 08:30 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2662
-
Benni Mack commented on patch set 6 04/16/20, 21:09
PermissionController.php:134do we really need this line? -
Oliver Hader commented on patch set 6 04/17/20, 06:02
PermissionController.php:134Reply UnresolvedProbably not, now that it's available in ModuleTemplate... -
Oliver Hader uploaded patch set 7 04/17/20, 06:02
-
TYPO3com voted on patch set 7 V +1 04/17/20, 06:15 Completed build in 13m 21s on Fri, 17 Apr, 06:15 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2682
-
Oliver Hader voted on patch set 7 CR -1 04/17/20, 11:18
-
Oliver Hader uploaded patch set 8 04/18/20, 12:32
-
Oliver Hader wrote 04/18/20, 12:35
Topic set to inline-javascript -
TYPO3com voted on patch set 8 V +1 04/18/20, 12:59 Completed build in 21m 10s on Sat, 18 Apr, 12:59 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2792
-
Oliver Hader uploaded patch set 9 04/18/20, 21:02
-
TYPO3com voted on patch set 9 V -1 04/18/20, 21:03 Completed build in 19s on Sat, 18 Apr, 09:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2824
-
Oliver Hader commented on patch set 9 04/18/20, 21:05
-
Oliver Hader uploaded patch set 10 04/19/20, 10:01
-
TYPO3com voted on patch set 10 V -1 04/19/20, 10:02 Completed build in 20s on Sun, 19 Apr, 10:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2834
-
Oliver Hader uploaded patch set 11 04/19/20, 10:06
-
TYPO3com voted on patch set 11 V -1 04/19/20, 10:07 Completed build in 20s on Sun, 19 Apr, 10:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2835
-
Oliver Hader voted on patch set 11 CR -1 04/19/20, 10:14
-
Oliver Hader uploaded patch set 12 04/19/20, 10:18
-
TYPO3com voted on patch set 12 V +1 04/19/20, 10:30 Completed build in 11m 52s on Sun, 19 Apr, 10:30 AM Test Summary: 73652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2836
-
Benni Mack voted on patch set 12 V +1 CR +1 04/19/20, 19:52
-
Andreas Kienast commented on patch set 12 V +1 04/20/20, 06:07
ActionDispatcher.ts:55UnresolvedThis method is unused. Is it obsolete or do we need it later™? -
Josef Glatz commented on patch set 12 V +1 CR +1 04/20/20, 09:08
* VERIFIED: Tested each part functionally in different browsers under macOS. ✅ -
Benni Mack voted on patch set 12 V +2 CR +2 04/20/20, 09:09
-
Benni Mack merged patch set 13 04/20/20, 09:09