Review 9.5 Merged

64140[BUGFIX] Don't render broken extension icons in language packs updater

Josef Glatz CR +2 V +2 Easy +5 −3 updated 04/16/20, 04:46

Commit message

The icon path of an extension is only returned if the icon can be found.
This prevents the JavaScript from rendering a broken extension icon.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Josef Glatz commented on patch set 1 04/15/20, 09:59

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/LanguagePacks.ts * typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/LanguagePacks.js
  2. TYPO3com voted on patch set 1 V -1 04/15/20, 10:37 Completed build in 26m 03s on Wed, 15 Apr, 10:37 AM Test Summary: 74399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-468

  3. Josef Glatz uploaded patch set 2 04/15/20, 19:27

  4. Josef Glatz commented on patch set 2 04/15/20, 19:27

    This change is ready for review.
  5. Josef Glatz commented on patch set 2 04/15/20, 19:29

    LanguagePacks.js:463 Unresolved

    - Fix already in 10 (master) - this fix is only necessary for 9.5
  6. TYPO3com voted on patch set 2 V +1 04/15/20, 19:40 Completed build in 12m 33s on Wed, 15 Apr, 07:40 PM Test Summary: 74787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-476

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 04/15/20, 20:48

  8. Georg Ringer voted on patch set 2 V +2 CR +2 04/16/20, 04:45

  9. Georg Ringer merged patch set 3 04/16/20, 04:46