Review 9.5 Merged

64141[TASK] Tune permission checks in TreeController

Tymoteusz Motylewski CR +2 V +2 Easy +4 −6 updated 04/19/20, 19:18

Commit message

Do not calculate permissions for every page, as we're limiting the pages
through SQL query constraints.

Fetch sys_language_uid and l10n_parent from db as they are required for
isInWebMount to prevent it from fetching row from db again.

Pass full row to isInWebMount in calcPerms instead of just uid.
isInWebMount has logic to handle translated records.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 34

  1. Tymoteusz Motylewski commented on patch set 1 04/17/20, 06:24

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/17/20, 06:45 Completed build in 19m 24s on Fri, 17 Apr, 06:45 AM Test Summary: 74789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-479

  3. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 04/19/20, 19:17

  4. Tymoteusz Motylewski merged patch set 2 04/19/20, 19:18