Review 9.5 Merged

64142[BUGFIX] Check if language is accessible in PageContentErrorHandler

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/24/20, 11:56

Commit message

The changes made in #90135 introduced a regression, that made the
PageContentErrorHandler ignore the enabled flag of the requested
language.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 04/17/20, 08:29

    Cherry Picked from branch master.
  2. Oliver Klee commented on patch set 1 04/17/20, 08:39

    PageContentErrorHandler.php:117 Unresolved

    Can we have a regression test for this?
  3. TYPO3com voted on patch set 1 V +1 04/17/20, 08:50 Completed build in 12m 00s on Fri, 17 Apr, 08:50 AM Test Summary: 74789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-480

  4. Benni Mack commented on patch set 1 V +2 CR +2 04/24/20, 11:56

    Hey Oli, as this is a backport, I would not modify this for the straight backport (and thus, only in v9) but create another patch with only the test afterwards. Hope that's OK with you. As you know: Thanks very much for the pointer!
  5. Benni Mack merged patch set 2 04/24/20, 11:56