Review 9.5 Merged

64146[TASK] Use more specific array type annotations in GeneralUtility

Daniel Goerz CR +2 V +2 Normal +27 −27 updated 06/05/20, 15:29

Commit message

Having PHPDoc parameter and return type annotations like "string[]"
instead of the generic "array" will help both static code analysers
as well as human readers.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Daniel Goerz commented on patch set 1 04/19/20, 11:43

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Utility/GeneralUtility.php * typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
  2. TYPO3com voted on patch set 1 V -1 04/19/20, 11:44 Completed build in 23s on Sun, 19 Apr, 11:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-488

  3. Daniel Goerz uploaded patch set 2 04/19/20, 11:55

  4. Daniel Goerz commented on patch set 2 04/19/20, 11:57

    This change is ready for review.
  5. Oliver Klee voted on patch set 2 CR +1 04/19/20, 12:05

  6. TYPO3com voted on patch set 2 V +1 04/19/20, 12:07 Completed build in 11m 59s on Sun, 19 Apr, 12:07 PM Test Summary: 74789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-489

  7. Daniel Goerz uploaded patch set 3 06/05/20, 14:40

  8. TYPO3com voted on patch set 3 V +1 06/05/20, 14:56 Completed build in 13m 32s on Fri, 5 Jun, 02:56 PM Test Summary: 74998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-686

  9. Daniel Goerz voted on patch set 3 V +2 CR +2 06/05/20, 15:29

  10. Daniel Goerz merged patch set 4 06/05/20, 15:29