Review main Merged

64154[TASK] Reduce inline JavaScript in ext:filelist

Oliver Hader CR +2 V +2 Hard +388 −166 updated 04/18/20, 12:38

Commit message

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings. There are still a couple of aspects
that need to be solved in a general way - e.g. assigning global
language labels (`TYPO3.lang`) or settings (`TYPO3.settings`).

* allows `Modal` confirmation to emit `ModalResponseEvent`
* extracts inline JavaScript from controllers & templates
* introduces `BroadcastChannel` in `nav_frame` (folder tree)
* uses plain links (`<a href="..."`) where applicable
* updates folder tree when navigating in browser history

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1523

  1. Oliver Hader uploaded patch set 1 04/13/20, 17:41

  2. TYPO3com voted on patch set 1 V -1 04/13/20, 17:52 Completed build in 11m 15s on Mon, 13 Apr, 05:52 PM Test Summary: 3 of 73923 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2456

  3. Oliver Hader uploaded patch set 2 04/14/20, 19:21

  4. TYPO3com voted on patch set 2 V -1 04/14/20, 19:33 Completed build in 11m 42s on Tue, 14 Apr, 07:33 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2531

  5. Oliver Hader uploaded patch set 3 04/15/20, 07:59

  6. TYPO3com voted on patch set 3 V -1 04/15/20, 08:00 Completed build in 29s on Wed, 15 Apr, 08:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2553

  7. Oliver Hader uploaded patch set 4 04/15/20, 08:05

  8. Oliver Hader commented on patch set 4 04/15/20, 08:05

    This change is ready for review.
  9. Oliver Hader voted on patch set 4 CR -1 04/15/20, 08:19

  10. TYPO3com voted on patch set 4 V +1 04/15/20, 08:27 Completed build in 14m 21s on Wed, 15 Apr, 08:27 AM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2554

  11. Oliver Hader uploaded patch set 5 04/15/20, 08:28

  12. TYPO3com voted on patch set 5 V +1 04/15/20, 08:49 Completed build in 18m 44s on Wed, 15 Apr, 08:49 AM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2558

  13. Andreas Kienast commented on patch set 5 CR -1 04/15/20, 14:52

    on it
  14. Andreas Kienast uploaded patch set 6 04/15/20, 15:26

  15. Andreas Kienast commented on patch set 6 V -1 04/15/20, 15:27

    Submit of file replacement leads to an empty page
  16. Andreas Kienast uploaded patch set 7 04/15/20, 15:34

  17. Andreas Kienast voted on patch set 7 V +1 CR +1 04/15/20, 15:38

  18. TYPO3com voted on patch set 6 V +1 04/15/20, 15:43 Completed build in 17m 12s on Wed, 15 Apr, 03:43 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2589

  19. TYPO3com voted on patch set 7 V -1 04/15/20, 15:50 Completed build in 15m 26s on Wed, 15 Apr, 03:50 PM Test Summary: 6 of 74007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2590

  20. TYPO3com voted on patch set 7 V +1 04/15/20, 15:56 Completed build in 37m 05s on Wed, 15 Apr, 03:56 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2590

  21. Benni Mack voted on patch set 7 V +2 CR +2 04/15/20, 15:59

  22. Benni Mack merged patch set 8 04/15/20, 15:59

  23. Oliver Hader wrote 04/18/20, 12:38

    Topic set to inline-javascript