Review main Merged

64158[TASK] PSR-12: Add empty lines at the beginning of PHP files

Benni Mack CR +2 V +2 Nightmare +3989 −39 updated 04/14/20, 11:59

Commit message

This change adds two changes
        'blank_line_after_opening_tag' => true,
        'single_trait_insert_per_statement' => true,

to our PHP-CS Fixer configuration, adopting more rules related
to PSR-12.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 3949

Show 3929 more files

Review log 1923

  1. Benni Mack uploaded patch set 1 04/14/20, 10:17

  2. Alexander Schnitzler voted on patch set 1 V +1 CR +1 04/14/20, 10:24

  3. TYPO3com voted on patch set 1 V -1 04/14/20, 10:31 Completed build in 13m 58s on Tue, 14 Apr, 10:31 AM Test Summary: 138 of 73941 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2480

  4. Andreas Kienast commented on patch set 1 CR -1 04/14/20, 10:43

    The extension scanner fixtures need adoption as well as they have hardcoded line numbers.
  5. Andreas Kienast uploaded patch set 2 04/14/20, 11:19

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 04/14/20, 11:24

  7. Josef Glatz voted on patch set 2 CR +1 04/14/20, 11:28

  8. Andreas Kienast uploaded patch set 3 04/14/20, 11:30

  9. TYPO3com voted on patch set 2 V +1 04/14/20, 11:33 Completed build in 14m 20s on Tue, 14 Apr, 11:33 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2485

  10. Josef Glatz voted on patch set 3 CR -1 04/14/20, 11:34

  11. Alexander Schnitzler commented on patch set 3 04/14/20, 11:38

    > Patch Set 3: Code-Review-1 Can you explain your -1 please?
  12. Josef Glatz voted on patch set 3 CR 0 04/14/20, 11:39

  13. Josef Glatz commented on patch set 3 04/14/20, 11:41

    > Patch Set 3: > > > Patch Set 3: Code-Review-1 > > Can you explain your -1 please? Because typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceVersionRecordMigrationTest.php and typo3/sysext/install/Classes/Updates/RowUpdater/WorkspaceVersionRecordsMigration.php are shown as newly added from patchset 2 to 3. Andy tried already to explain me, but I don't get it why those files are shown as added
  14. Alexander Schnitzler commented on patch set 3 04/14/20, 11:41

    > Patch Set 3: > > > Patch Set 3: > > > > > Patch Set 3: Code-Review-1 > > > > Can you explain your -1 please? > > Because > typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceVersionRecordMigrationTest.php and typo3/sysext/install/Classes/Updates/RowUpdater/WorkspaceVersionRecordsMigration.php are shown as newly added from patchset 2 to 3. > > Andy tried already to explain me, but I don't get it why those files are shown as added I guess Andi rebased the patch while updating.
  15. Andreas Kienast uploaded patch set 4 04/14/20, 11:43

  16. Andreas Kienast voted on patch set 4 V +1 CR +1 04/14/20, 11:45

  17. Josef Glatz voted on patch set 4 V +1 CR +1 04/14/20, 11:45

  18. Oli Bartsch voted on patch set 4 V +1 CR +1 04/14/20, 11:45

  19. Alexander Schnitzler voted on patch set 4 V +1 CR +1 04/14/20, 11:47

  20. TYPO3com voted on patch set 3 V +1 04/14/20, 11:50 Completed build in 19m 30s on Tue, 14 Apr, 11:50 AM Test Summary: 73463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2487

  21. Andreas Kienast voted on patch set 4 V +2 CR +2 04/14/20, 11:53

  22. TYPO3com voted on patch set 4 V +1 04/14/20, 11:59 Completed build in 15m 35s on Tue, 14 Apr, 11:59 AM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2489

  23. Andreas Kienast merged patch set 5 04/14/20, 11:59