Review main Merged

64159[TASK] Set php header comment via php-cs-fixer

Alexander Schnitzler CR +2 V +2 Impossible +8422 −6577 updated 04/15/20, 07:13

Commit message

With this patch, the header comment of php files is
automatically added by the php-cs-fixer, which guarantees
that its format and place of occurrence remain the same
in all files.

Files that are copied over from other projects are excluded.

Furthermore, files that are kind of inspired by other
projects also get the same header comment but may have
a second, additional comment explaining its origin.

Used command:

    bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3733

Show 3713 more files

Review log 2235

Show 710 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 04/14/20, 10:44

  2. TYPO3com voted on patch set 1 V -1 04/14/20, 10:57 Completed build in 12m 50s on Tue, 14 Apr, 10:57 AM Test Summary: 138 of 73941 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2483

  3. Alexander Schnitzler uploaded patch set 2 04/14/20, 11:27

  4. TYPO3com voted on patch set 2 V -1 04/14/20, 11:45 Completed build in 15m 54s on Tue, 14 Apr, 11:45 AM Test Summary: 138 of 73947 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2486

  5. Alexander Schnitzler uploaded patch set 3 04/14/20, 12:40

  6. Alexander Schnitzler commented on patch set 3 04/14/20, 12:41

    This change is ready for review.
  7. Benni Mack commented on patch set 3 04/14/20, 12:46

    I'll adapt the commit message once Bamboo is green.
  8. Andreas Kienast commented on patch set 3 04/14/20, 12:47

    I'm not sure about this patch, as it affects 3rd party scripts having their own copyright notices.
  9. Alexander Schnitzler commented on patch set 3 04/14/20, 12:55

    > Patch Set 3: > > I'm not sure about this patch, as it affects 3rd party scripts having their own copyright notices. I am very sure about this patch. If there is a problem with single files, we will find a solution. If we just copied stuff from other projects, we maybe don't need to run cgl stuff on them. If that's what it takes to enable automation for our whole codebase, we can very well live with that.
  10. TYPO3com voted on patch set 3 V +1 04/14/20, 13:00 Completed build in 19m 48s on Tue, 14 Apr, 01:00 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2498

  1. Alexander Schnitzler uploaded patch set 4 04/14/20, 13:35

  2. TYPO3com voted on patch set 4 V +1 04/14/20, 13:56 Completed build in 21m 43s on Tue, 14 Apr, 01:56 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2504

  3. Alexander Schnitzler uploaded patch set 5 04/14/20, 14:51

  4. TYPO3com voted on patch set 5 V +1 04/14/20, 15:05 Completed build in 13m 10s on Tue, 14 Apr, 03:05 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2512

  5. Alexander Schnitzler uploaded patch set 6 04/14/20, 16:20

  6. TYPO3com voted on patch set 6 V -1 04/14/20, 16:23 Completed build in 02m 49s on Tue, 14 Apr, 04:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2519

  7. Alexander Schnitzler uploaded patch set 7 04/14/20, 16:43

  8. TYPO3com voted on patch set 7 V +1 04/14/20, 16:59 Completed build in 16m 09s on Tue, 14 Apr, 04:59 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2520

  9. Alexander Schnitzler voted on patch set 7 CR -1 04/14/20, 17:03

  10. Alexander Schnitzler uploaded patch set 8 04/14/20, 17:05

  11. Alexander Schnitzler uploaded patch set 9 04/14/20, 17:17

  12. TYPO3com voted on patch set 8 V +1 04/14/20, 17:19 Completed build in 13m 47s on Tue, 14 Apr, 05:19 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2522

  13. Alexander Schnitzler uploaded patch set 10 04/14/20, 17:29

  14. TYPO3com voted on patch set 9 V +1 04/14/20, 17:32 Completed build in 14m 07s on Tue, 14 Apr, 05:32 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2523

  15. TYPO3com voted on patch set 10 V +1 04/14/20, 17:44 Completed build in 14m 16s on Tue, 14 Apr, 05:44 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2524

  16. Alexander Schnitzler uploaded patch set 11 04/14/20, 17:45

  17. Alexander Schnitzler uploaded patch set 12 04/14/20, 17:56

  18. Alexander Schnitzler commented on patch set 12 04/14/20, 17:58

    Alrighty, ready for review now. Finally...
  19. TYPO3com voted on patch set 11 V +1 04/14/20, 18:00 Completed build in 14m 54s on Tue, 14 Apr, 06:00 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2526

  20. Alexander Schnitzler uploaded patch set 13 04/14/20, 18:16

  21. TYPO3com voted on patch set 12 V +1 04/14/20, 18:17 Completed build in 20m 58s on Tue, 14 Apr, 06:17 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2527

  22. TYPO3com voted on patch set 13 V +1 04/14/20, 18:37 Completed build in 20m 22s on Tue, 14 Apr, 06:37 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2530

  23. Andreas Kienast voted on patch set 13 V +1 CR +1 04/15/20, 07:11

  24. Benni Mack voted on patch set 13 V +2 CR +2 04/15/20, 07:13

  25. Benni Mack merged patch set 14 04/15/20, 07:13