Review main Merged

64160[BUGFIX] Let DataHandler::getAutoVersionId return proper integer

Manuel Selbach CR +2 V +2 Easy +6 −7 updated 04/15/20, 08:18

Commit message

With this change the method DataHandler::getAutoVersionId will return
null or a proper integer value to reduce the complexity at other places
to bring it in the right format.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Manuel Selbach uploaded patch set 1 04/14/20, 11:48

  2. TYPO3com voted on patch set 1 V +1 04/14/20, 12:05 Completed build in 16m 29s on Tue, 14 Apr, 12:05 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2490

  3. Manuel Selbach commented on patch set 1 04/14/20, 12:59

    This change is ready for review.
  4. Benni Mack voted on patch set 1 V +1 CR +1 04/14/20, 14:29

  5. Alexander Schnitzler commented on patch set 1 04/14/20, 14:58

    DataHandler.php:8340 Unresolved

    What about adding a strict return type here as well?
  6. Manuel Selbach uploaded patch set 2 04/14/20, 17:57

  7. Alexander Schnitzler voted on patch set 2 V +1 CR +1 04/14/20, 18:03

  8. TYPO3com voted on patch set 2 V -1 04/14/20, 18:11 Completed build in 14m 34s on Tue, 14 Apr, 06:11 PM Test Summary: 73199 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2528

  9. TYPO3com voted on patch set 2 V +1 04/14/20, 18:20 Completed build in 38m 09s on Tue, 14 Apr, 06:20 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2528

  10. Oliver Klee voted on patch set 2 CR +1 04/14/20, 19:09

  11. Benni Mack voted on patch set 2 V +2 CR +2 04/15/20, 08:18

  12. Benni Mack merged patch set 3 04/15/20, 08:18