Review main Merged

64161[BUGFIX] Fix extension scanner Index.rst filename parsing

Benjamin Franzke CR +2 V +2 Easy +10 −8 updated 04/14/20, 14:31

Commit message

Rst files may not contain issue numbers. The extension scanner
iterates all .rst files (including Index.rst) which cases a type
error for typo3/sysext/core/Documentation/Changelog/7.0/Index.rst

(1/1) TypeError
Return value of
TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::parseIssueId()
must be of the type string, null returned

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 912

  1. Benjamin Franzke uploaded patch set 1 04/14/20, 11:54

  2. TYPO3com voted on patch set 1 V +1 04/14/20, 12:08 Completed build in 14m 01s on Tue, 14 Apr, 12:08 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2491

  3. Benjamin Franzke updated the commit message in patch set 2 04/14/20, 12:59

  4. Josef Glatz voted on patch set 2 V +1 CR +1 04/14/20, 13:09

  5. TYPO3com voted on patch set 2 V +1 04/14/20, 13:13 Completed build in 13m 51s on Tue, 14 Apr, 01:13 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2502

  6. Björn Jacob commented on patch set 2 04/14/20, 13:37

    Two nitpicks ;)
    "issue"
    "including"
  7. Josef Glatz updated the commit message in patch set 3 04/14/20, 13:39

  8. Josef Glatz commented on patch set 3 V +1 CR +1 04/14/20, 13:39

    Reply

    Done

    Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 04/14/20, 14:00 Completed build in 14m 05s on Tue, 14 Apr, 02:00 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2506

  10. Björn Jacob commented on patch set 3 CR +1 04/14/20, 14:03

    Thx friends :)
  11. Georg Ringer voted on patch set 3 V +2 CR +2 04/14/20, 14:31

  12. Georg Ringer merged patch set 4 04/14/20, 14:31