64163[TASK] PSR-12: Add unified new statements and argument spacing
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Alexander Schnitzler +1
-
Verified V +2 Done
- Georg Ringer +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 86
- Build/Scripts/annotationChecker.php+1 −1
- Build/Scripts/docBlockChecker.php+1 −1
- Build/.php_cs+4 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowInitializeNewTest.php+24 −24
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+18 −18
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessCommonTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessFieldLabelsTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessRecordTitleTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessShowitemTest.php+7 −7
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexPrepareTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php+22 −22
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineExpandCollapseStateTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInputPlaceholdersTest.php+9 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+12 −12
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+22 −22
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+56 −56
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+2 −2
Show 66 more files
- typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Middleware/SiteResolverTest.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/MemcachedBackend.php+1 −1
- typo3/sysext/core/Classes/Context/UserAspect.php+1 −1
- typo3/sysext/core/Classes/Controller/FileDumpController.php+2 −2
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/Localization/Locales.php+1 −1
- typo3/sysext/core/Classes/ServiceProvider.php+3 −3
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Console/CommandRegistryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestServiceProvider.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php+4 −4
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+3 −3
- typo3/sysext/core/Tests/Unit/EventDispatcher/EventDispatcherTest.php+7 −7
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Http/AbstractApplicationTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/ClientTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/MiddlewareDispatcherTest.php+30 −30
- typo3/sysext/core/Tests/Unit/Http/MiddlewareStackResolverTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php+1 −1
- typo3/sysext/core/Tests/UnitDeprecated/Compatibility/PublicPropertyDeprecationTraitTest.php+1 −1
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/LocallangXmlParserTest.php+5 −5
- typo3/sysext/core/Tests/UnitDeprecated/Localization/LocalizationFactoryTest.php+1 −1
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Service/CacheService.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/ConjunctionValidator.php+1 −1
- typo3/sysext/extbase/Configuration/Services.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest.php+10 −10
- typo3/sysext/extbase/Tests/Functional/Property/PropertyMapperTest.php+9 −9
- typo3/sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/ObjectStorageTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/Validation/Validator/DummyValidator.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DateTimeValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/UrlValidatorTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/ExtensionTest.php+1 −1
- typo3/sysext/felogin/Tests/Unit/Service/ValidatorResolverServiceTest.php+1 −1
- typo3/sysext/fluid/Configuration/Services.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Widget/Controller/PaginateControllerTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+3 −3
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+4 −4
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Runtime/FormRuntimeTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/TypoScriptServiceTest.php+1 −1
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+2 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/MenuContentObjectFactoryTest.php+7 −7
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/PageArgumentValidatorTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteBaseRedirectResolverTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/StaticRouteResolverTest.php+1 −1
- typo3/sysext/install/Classes/Middleware/Maintenance.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck.php+2 −2
- typo3/sysext/install/Classes/ServiceProvider.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ClassNameMatcherFixture.php+2 −2
- typo3/sysext/reports/Tests/Unit/Report/Status/Typo3StatusTest.php+2 −2
Review log 813
-
Benni Mack uploaded patch set 1 04/14/20, 12:44
-
TYPO3com voted on patch set 1 V -1 04/14/20, 13:09 Completed build in 19m 36s on Tue, 14 Apr, 01:09 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2501
-
Andreas Kienast uploaded patch set 2 04/14/20, 13:37
-
TYPO3com voted on patch set 2 V -1 04/14/20, 13:51 Completed build in 14m 08s on Tue, 14 Apr, 01:51 PM Test Summary: 73151 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2505
-
TYPO3com voted on patch set 2 V +1 04/14/20, 14:04 Completed build in 41m 32s on Tue, 14 Apr, 02:04 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2505
-
Alexander Schnitzler commented on patch set 2 04/14/20, 14:55
-
Andreas Kienast commented on patch set 2 04/15/20, 07:42
duplicateExceptionCodeCheck.sh:18Reply UnresolvedBecause ListenerProviderTest.php throws a BadMethodCallException and this scripts finds it now -
Benni Mack uploaded patch set 3 04/15/20, 09:41
-
TYPO3com voted on patch set 3 V -1 04/15/20, 10:18 Completed build in 37m 19s on Wed, 15 Apr, 10:18 AM Test Summary: 11 of 72728 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2565
-
TYPO3com voted on patch set 3 V +1 04/15/20, 11:28 Completed build in 2h 24m 21s on Wed, 15 Apr, 11:28 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2565
-
Alexander Schnitzler voted on patch set 3 V +1 CR +1 04/15/20, 11:37
-
Georg Ringer voted on patch set 3 V +2 CR +2 04/15/20, 12:42
-
Georg Ringer merged patch set 4 04/15/20, 12:42
duplicateExceptionCodeCheck.sh:18