Review main Merged

64163[TASK] PSR-12: Add unified new statements and argument spacing

Benni Mack CR +2 V +2 Hard +412 −408 updated 04/15/20, 12:42

Commit message

TYPO3's PHP-CS-Fixer configuration is adapted
to move towards the PSR-12 standard by unifying the
new statement and adding proper braces argument methods
and arguments.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 86

Show 66 more files

Review log 813

  1. Benni Mack uploaded patch set 1 04/14/20, 12:44

  2. TYPO3com voted on patch set 1 V -1 04/14/20, 13:09 Completed build in 19m 36s on Tue, 14 Apr, 01:09 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2501

  3. Andreas Kienast uploaded patch set 2 04/14/20, 13:37

  4. TYPO3com voted on patch set 2 V -1 04/14/20, 13:51 Completed build in 14m 08s on Tue, 14 Apr, 01:51 PM Test Summary: 73151 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2505

  5. TYPO3com voted on patch set 2 V +1 04/14/20, 14:04 Completed build in 41m 32s on Tue, 14 Apr, 02:04 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2505

  6. Alexander Schnitzler commented on patch set 2 04/14/20, 14:55

    duplicateExceptionCodeCheck.sh:18

    Can you shortly explain why this exclude is necessary in the context of this patch?
  7. Andreas Kienast commented on patch set 2 04/15/20, 07:42

    duplicateExceptionCodeCheck.sh:18 Reply Unresolved

    Because ListenerProviderTest.php throws a BadMethodCallException and this scripts finds it now
  8. Benni Mack uploaded patch set 3 04/15/20, 09:41

  9. TYPO3com voted on patch set 3 V -1 04/15/20, 10:18 Completed build in 37m 19s on Wed, 15 Apr, 10:18 AM Test Summary: 11 of 72728 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2565

  10. TYPO3com voted on patch set 3 V +1 04/15/20, 11:28 Completed build in 2h 24m 21s on Wed, 15 Apr, 11:28 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2565

  11. Alexander Schnitzler voted on patch set 3 V +1 CR +1 04/15/20, 11:37

  12. Georg Ringer voted on patch set 3 V +2 CR +2 04/15/20, 12:42

  13. Georg Ringer merged patch set 4 04/15/20, 12:42