Review main Merged

64164[BUGFIX] Load the correct "first module"

Andreas Kienast CR +2 V +2 Easy +25 −0 updated 04/14/20, 14:30

Commit message

The start up option "First module in menu" is a misleading in some ways.
The select box e.g. has "dashboard" as first selectable option, but in
such cases the "help_AboutAbout" module is loaded instead, for example.
This is due the fact the first module is determined via querying the DOM
for the first element matching the selector
`.t3js-modulemenu-action[data-link]`.

The behavior is now changed to load the first module as listed in the
previously mentioned select box.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1

Issues 1

Files 1

Review log 45

  1. Andreas Kienast uploaded patch set 1 04/14/20, 14:18

  2. Richard Haeser voted on patch set 1 V +1 CR +1 04/14/20, 14:27

  3. Georg Ringer voted on patch set 1 V +2 CR +2 04/14/20, 14:29

  4. Georg Ringer merged patch set 2 04/14/20, 14:29

  5. TYPO3com voted on patch set 1 V +1 04/14/20, 14:30 Completed build in 12m 03s on Tue, 14 Apr, 02:30 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2509