Review main Merged

64167[BUGFIX] Use empty alt text for EM extension icons

Oliver Klee CR +2 V +2 Easy +2 −2 updated 04/14/20, 16:35

Commit message

For images that cannot be loaded (e.g., when the extension is outside
the document root), the extension name will be printed twice, which
looks ugly and also breaks the layout.

As the extension icon is purely decorative, the alt attribute should
be an empty string.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Björn Jacob +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Björn Jacob +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Oliver Klee uploaded patch set 1 04/14/20, 15:33

  2. TYPO3com voted on patch set 1 V +1 04/14/20, 15:49 Completed build in 16m 03s on Tue, 14 Apr, 03:49 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2515

  3. Björn Jacob voted on patch set 1 V +1 CR +1 04/14/20, 15:54

  4. Christian Eßl voted on patch set 1 V +1 CR +1 04/14/20, 16:16

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 04/14/20, 16:19

  6. Josef Glatz voted on patch set 1 V +1 CR +1 04/14/20, 16:19

  7. Georg Ringer voted on patch set 1 V +2 CR +2 04/14/20, 16:32

  8. Georg Ringer merged patch set 2 04/14/20, 16:32

  9. Oliver Klee commented on patch set 2 04/14/20, 16:35

    Wow, that was quick! Thanks, everybody!