Review 9.5 Merged

64168[BUGFIX] Use empty alt text for EM extension icons

Georg Ringer CR +2 V +2 Easy +2 −2 updated 04/14/20, 16:52

Commit message

For images that cannot be loaded (e.g., when the extension is outside
the document root), the extension name will be printed twice, which
looks ugly and also breaks the layout.

As the extension icon is purely decorative, the alt attribute should
be an empty string.

Review

  • Code review CR +2 Done
    • Christian Eßl +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Eßl +2
    • Oli Bartsch +1
    • Oliver Klee +1

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 04/14/20, 16:36

  2. Georg Ringer updated the commit message in patch set 2 04/14/20, 16:36

  3. Georg Ringer commented on patch set 2 04/14/20, 16:36

    This change is ready for review.
  4. Oliver Klee voted on patch set 2 V +1 CR +1 04/14/20, 16:44

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 04/14/20, 16:45

  6. Christian Eßl voted on patch set 2 V +2 CR +2 04/14/20, 16:46

  7. Christian Eßl merged patch set 3 04/14/20, 16:46

  8. TYPO3com voted on patch set 2 V +1 04/14/20, 16:52 Completed build in 14m 30s on Tue, 14 Apr, 04:52 PM Test Summary: 74769 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-463