64170[BUGFIX] Remove invalid doctype annotations from GeneralUtility
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Alexander Schnitzler +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Alexander Schnitzler +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1014
-
TYPO3com uploaded patch set 1 04/14/20, 18:19
-
Alexander Schnitzler commented on patch set 1 04/14/20, 18:23
Question: Why does this happen? Is there a stack trace? I am asking because those doctrine annotation issues are usually triggered when creating a ClassSchema object of a class which is instantiated which must never happen with GeneralUtility. -
TYPO3com voted on patch set 1 V +1 04/14/20, 18:31 Completed build in 12m 18s on Tue, 14 Apr, 06:31 PM Test Summary: 74769 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-465
-
Benni Mack commented on patch set 1 CR -1 04/15/20, 12:43
I'd like to name it bugfix and the commit message seems a bit ... hmm ;) -
Benni Mack updated the commit message in patch set 2 04/15/20, 12:48
-
Alexander Schnitzler commented on patch set 2 CR -1 04/15/20, 12:54
Unresolved
We don't have those in master any more. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/61517 -
TYPO3com voted on patch set 2 V +1 04/15/20, 13:44 Completed build in 39m 56s on Wed, 15 Apr, 01:44 PM Test Summary: 74775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-469
-
Alexander Schnitzler updated the commit message in patch set 3 04/15/20, 14:22
-
TYPO3com voted on patch set 3 V +1 04/15/20, 14:43 Completed build in 19m 30s on Wed, 15 Apr, 02:43 PM Test Summary: 74775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-472
-
Andreas Kienast voted on patch set 3 V +1 CR +1 04/15/20, 14:48
-
Alexander Schnitzler voted on patch set 3 V +1 CR +1 04/15/20, 14:50
-
Oliver Klee voted on patch set 3 CR +1 04/15/20, 15:37
-
Benni Mack voted on patch set 3 V +2 CR +2 04/15/20, 15:45
-
Benni Mack merged patch set 4 04/15/20, 15:45