64174[BUGFIX] Calculate page permissions only once in TreeController
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 1
Review log 57
-
Tymoteusz Motylewski uploaded patch set 1 04/14/20, 21:28
-
TYPO3com voted on patch set 1 V -1 04/14/20, 21:28 Completed build in 24s on Tue, 14 Apr, 09:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2537
-
Tymoteusz Motylewski uploaded patch set 2 04/14/20, 21:29
-
TYPO3com voted on patch set 2 V +1 04/14/20, 21:40 Completed build in 11m 15s on Tue, 14 Apr, 09:40 PM Test Summary: 73518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2538
-
Markus Klein commented on patch set 2 04/15/20, 06:51
How much is the performance gain here? What I see is that you basically built a runtime cache around some `GeneralUtility::inList()` calls, right? Are those so expensive?TreeController.php:105Unresolved?boolTreeController.php:307Unresolvedthis is superfluous as it is covered inside the BackendUserAuthentication::calcPerms methodTreeController.php:518Unresolvedwould not be needed if BackendUserAuthentication::checkLanguageAccess would do that check as well. It is already covered in BackendUserAuthentication::check method. -
Benni Mack updated the commit message in patch set 3 05/25/20, 18:47
-
Tymoteusz Motylewski abandoned the change 08/28/20, 11:12