64175[TASK] Tune permission checks in TreeController
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Markus Klein +1
- Benni Mack +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Markus Klein +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 3
Review log 1213
-
Tymoteusz Motylewski uploaded patch set 1 04/14/20, 22:04
-
TYPO3com voted on patch set 1 V +1 04/14/20, 22:19 Completed build in 14m 11s on Tue, 14 Apr, 10:19 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2542
-
Benni Mack voted on patch set 1 CR +1 04/15/20, 06:20
-
Markus Klein commented on patch set 1 CR +1 04/15/20, 06:55
-
Markus Klein commented on patch set 1 CR 0 04/15/20, 06:59
TreeController.php:418Why is it safe to remove this check? What if a user got an entry point assigned but has no permissions on this page? (That's the case covered here, I presume) -
Benni Mack commented on patch set 1 04/15/20, 07:48
TreeController.php:418ReplyMy last change introduced a DatabaseRestriction which only fetches the records that have this rule applied already on a DB query level... -
Markus Klein commented on patch set 1 04/15/20, 08:00
TreeController.php:418Replylovely -
Markus Klein voted on patch set 1 CR +1 04/15/20, 08:00
-
Markus Klein commented on patch set 1 04/15/20, 08:01
BackendUserAuthentication.php:596ReplyDone -
Markus Klein commented on patch set 1 V +1 04/15/20, 08:20
Tested with a tree of 11k pages with up to 7 levels. Speedup of 50% confirmed. NICE! -
Benni Mack voted on patch set 1 V +1 04/17/20, 06:09
-
Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 04/17/20, 06:23
-
Tymoteusz Motylewski merged patch set 2 04/17/20, 06:23
BackendUserAuthentication.php:596