Review main Merged

64175[TASK] Tune permission checks in TreeController

Tymoteusz Motylewski CR +2 V +2 Easy +4 −6 updated 04/17/20, 06:23

Commit message

Do not calculate permissions for every page, as we're limiting the pages
through SQL query constraints.

Fetch sys_language_uid and l10n_parent from db as they are required for
isInWebMount to prevent it from fetching row from db again.

Pass full row to isInWebMount in calcPerms instead of just uid.
isInWebMount has logic to handle translated records.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Markus Klein +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1213

  1. Tymoteusz Motylewski uploaded patch set 1 04/14/20, 22:04

  2. TYPO3com voted on patch set 1 V +1 04/14/20, 22:19 Completed build in 14m 11s on Tue, 14 Apr, 10:19 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2542

  3. Benni Mack voted on patch set 1 CR +1 04/15/20, 06:20

  4. Markus Klein commented on patch set 1 CR +1 04/15/20, 06:55

    BackendUserAuthentication.php:596

    nice catch!!
  5. Markus Klein commented on patch set 1 CR 0 04/15/20, 06:59

    TreeController.php:418

    Why is it safe to remove this check? What if a user got an entry point assigned but has no permissions on this page? (That's the case covered here, I presume)
  6. Benni Mack commented on patch set 1 04/15/20, 07:48

    TreeController.php:418 Reply

    My last change introduced a DatabaseRestriction which only fetches the records that have this rule applied already on a DB query level...
  7. Markus Klein commented on patch set 1 04/15/20, 08:00

    TreeController.php:418 Reply

    lovely
  8. Markus Klein voted on patch set 1 CR +1 04/15/20, 08:00

  9. Markus Klein commented on patch set 1 04/15/20, 08:01

    BackendUserAuthentication.php:596 Reply

    Done
  10. Markus Klein commented on patch set 1 V +1 04/15/20, 08:20

    Tested with a tree of 11k pages with up to 7 levels. Speedup of 50% confirmed. NICE!
  11. Benni Mack voted on patch set 1 V +1 04/17/20, 06:09

  12. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 04/17/20, 06:23

  13. Tymoteusz Motylewski merged patch set 2 04/17/20, 06:23