Review main Merged

64176[BUGFIX] Don't render broken extension icons in language packs updater

Josef Glatz CR +2 V +2 Easy +5 −3 updated 04/15/20, 09:47

Commit message

The icon path of an extension is only returned if the icon can be found.
This prevents the JavaScript from rendering a broken extension icon.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1317

  1. Josef Glatz uploaded patch set 1 04/15/20, 04:21

  2. Josef Glatz commented on patch set 1 04/15/20, 04:21

    This change is ready for review.
  3. Andreas Kienast commented on patch set 1 CR -1 04/15/20, 04:24

    LanguagePacks.ts:445 Unresolved

    typeof extension.icon !== 'undefined'
  4. TYPO3com voted on patch set 1 V +1 04/15/20, 04:33 Completed build in 12m 00s on Wed, 15 Apr, 04:33 AM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2543

  5. Josef Glatz uploaded patch set 2 04/15/20, 04:33

  6. Josef Glatz commented on patch set 2 04/15/20, 04:34

    @Andy, please can you also test in your browser and check your console if you're getting also that request on domain.tld/undefined. I cannot find the place in the LanguagePacks.ts which is responsible for
  7. Andreas Kienast commented on patch set 2 V -1 04/15/20, 04:40

    > Patch Set 2: > > @Andy, please can you also test in your browser and check your console if you're getting also that request on domain.tld/undefined. I cannot find the place in the LanguagePacks.ts which is responsible for Can confirm.
  8. Andreas Kienast commented on patch set 2 CR -1 04/15/20, 04:42

    on it

    LanguagePacks.ts:445

    undefined must be in quotes...
  9. Andreas Kienast uploaded patch set 3 04/15/20, 04:42

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 04/15/20, 04:43

  11. Josef Glatz commented on patch set 3 04/15/20, 04:52

    ahh, yesss.. need some coffee now ;-)

    LanguagePacks.ts:445 Reply

    Ack
  12. TYPO3com voted on patch set 2 V -1 04/15/20, 05:09 Completed build in 35m 43s on Wed, 15 Apr, 05:09 AM Test Summary: 11 of 74006 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2544

  13. TYPO3com voted on patch set 3 V -1 04/15/20, 05:28 Completed build in 29m 53s on Wed, 15 Apr, 05:28 AM Test Summary: 13 of 74004 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2545

  14. TYPO3com voted on patch set 3 V +1 04/15/20, 05:38 Completed build in 19m 40s on Wed, 15 Apr, 05:38 AM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2546

  15. Oli Bartsch voted on patch set 3 V +1 CR +1 04/15/20, 06:27

  16. Georg Ringer voted on patch set 3 V +2 CR +2 04/15/20, 09:47

  17. Georg Ringer merged patch set 4 04/15/20, 09:47