Review main Merged

64180[TASK] Include all classes via use statements in ext:extbase

Alexander Schnitzler CR +2 V +2 Nightmare +2325 −1536 updated 04/15/20, 18:45

Commit message

This patch has been created with rector and php-cs-fixer

    bin/rector process --set=php53 typo3/sysext/extbase/Classes
    bin/rector process --set=php53 typo3/sysext/extbase/Tests

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Benni Mack +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 236

Show 216 more files

Review log 1726

Show 1 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 04/15/20, 11:11

  1. TYPO3com voted on patch set 1 V -1 04/15/20, 11:30 Completed build in 17m 58s on Wed, 15 Apr, 11:29 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2568

  2. Alexander Schnitzler uploaded patch set 2 04/15/20, 11:34

  3. TYPO3com voted on patch set 2 V +1 04/15/20, 11:50 Completed build in 15m 52s on Wed, 15 Apr, 11:50 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2570

  4. Alexander Schnitzler uploaded patch set 3 04/15/20, 12:20

  5. TYPO3com voted on patch set 3 V -1 04/15/20, 13:16 Completed build in 47m 22s on Wed, 15 Apr, 01:16 PM Test Summary: 1 of 74007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2575

  6. Alexander Schnitzler uploaded patch set 4 04/15/20, 13:37

  7. TYPO3com voted on patch set 3 V +1 04/15/20, 14:01 Completed build in 2h 19m 05s on Wed, 15 Apr, 02:01 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2575

  8. TYPO3com voted on patch set 4 V +1 04/15/20, 14:21 Completed build in 25m 57s on Wed, 15 Apr, 02:21 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2583

  9. Benni Mack commented on patch set 4 V +2 CR +2 04/15/20, 15:38

    AbstractConfigurationManager.php:44

    what should happen to these things?
  10. Benni Mack voted on patch set 4 V 0 CR 0 04/15/20, 15:38

  11. Benni Mack updated the commit message in patch set 5 04/15/20, 15:42

  12. Alexander Schnitzler commented on patch set 5 04/15/20, 15:42

    AbstractConfigurationManager.php:44 Reply

    We can let rector shorten those as well if we want.
  13. Benni Mack voted on patch set 5 V +1 CR +1 04/15/20, 15:43

  14. Benni Mack commented on patch set 5 04/15/20, 15:44

    AbstractConfigurationManager.php:44 Reply Unresolved

    separate patch...
  15. TYPO3com voted on patch set 5 V +1 04/15/20, 15:56 Completed build in 14m 11s on Wed, 15 Apr, 03:56 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2591

  16. Andreas Kienast uploaded patch set 6 04/15/20, 16:01

  17. Andreas Kienast voted on patch set 6 V +1 CR +1 04/15/20, 16:02

  18. Alexander Schnitzler commented on patch set 6 04/15/20, 16:02

    thx for rebasing
  19. TYPO3com voted on patch set 6 V -1 04/15/20, 16:15 Completed build in 13m 03s on Wed, 15 Apr, 04:15 PM Test Summary: 73257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2593

  20. TYPO3com voted on patch set 6 V +1 04/15/20, 16:21 Completed build in 32m 24s on Wed, 15 Apr, 04:21 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2593

  21. Alexander Schnitzler updated the commit message in patch set 7 04/15/20, 16:37

  22. TYPO3com voted on patch set 7 V +1 04/15/20, 17:02 Completed build in 24m 09s on Wed, 15 Apr, 05:02 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2598

  23. Benni Mack voted on patch set 7 V +1 CR +1 04/15/20, 18:34

  24. Alexander Schnitzler commented on patch set 7 V +2 CR +2 04/15/20, 18:45

    Counting in the votes of Andi. Only change since his +1 was changing the commit msg.
  25. Alexander Schnitzler merged patch set 8 04/15/20, 18:45