64182[BUGFIX] Fix type error in log upgrade wizard
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 3541
Show 1316 earlier messages
-
Georg Großberger uploaded patch set 1 04/15/20, 11:44
-
TYPO3com voted on patch set 1 V +1 04/15/20, 11:59 Completed build in 14m 33s on Wed, 15 Apr, 11:59 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2572
-
Oliver Klee voted on patch set 1 CR +1 04/15/20, 12:02
-
Benni Mack voted on patch set 1 CR +1 04/15/20, 12:26
-
Alexander Schnitzler commented on patch set 1 CR -1 04/15/20, 12:31
-
Jonas Eberle uploaded patch set 2 04/18/20, 13:27
-
Oliver Hader commented on patch set 2 CR -1 04/18/20, 13:55
SeparateSysHistoryFromSysLogUpdate.php:174In case `$row['log_data']` is null, it will issue a warning... Probably you want to have `unserialize($row['log_data'] ?? '', ['allowed_classes' => false]);` -
TYPO3com voted on patch set 2 V -1 04/18/20, 13:56 Completed build in 24m 15s on Sat, 18 Apr, 01:56 PM Test Summary: 36 of 74111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2804
-
Alexander Schnitzler commented on patch set 2 04/18/20, 14:15
SeparateSysHistoryFromSysLogUpdate.php:174ReplyOr ?? 'a:0:{}' like further down in the patch. -
Jonas Eberle commented on patch set 2 04/18/20, 15:10
SeparateSysHistoryFromSysLogUpdate.php:174Replyunserialize() AFAIK only returns null for "N;". And anyways is_array(null) === false. Errors return false and trigger E_NOTICE https://www.php.net/manual/en/function.unserialize.php. PHP docs are shite though because they do not mention the possible null return value... Funily, unserialize(null) does not trigger an E_NOTICE but still returns false. I avoided the previous `?? 'a:0:{}'` because it was smelly IMHO. Please change as you like. I just wanted to push that patch forward to shorten the list https://forge.typo3.org/projects/typo3cms-core/issues?utf8=%E2%9C%93&set_filter=1&f%5B%5D=status_id&op%5Bstatus_id%5D=%3D&v%5Bstatus_id%5D%5B%5D=11&v%5Bstatus_id%5D%5B%5D=8&f%5B%5D=fixed_version_id&op%5Bfixed_version_id%5D=%3D&v%5Bfixed_version_id%5D%5B%5D=3574&f%5B%5D=category_id&op%5Bcategory_id%5D=%21&v%5Bcategory_id%5D%5B%5D=1684&v%5Bcategory_id%5D%5B%5D=1107&f%5B%5D=&c%5B%5D=tracker&c%5B%5D=status&c%5B%5D=priority&c%5B%5D=subject&c%5B%5D=assigned_to&c%5B%5D=category&c%5B%5D=fixed_version&c%5B%5D=cf_7&group_by=&t%5B%5D= -
Alexander Schnitzler commented on patch set 2 04/18/20, 15:21
SeparateSysHistoryFromSysLogUpdate.php:174ReplyIt's less about what is put into unserialize, it's more that there will be an error triggered if $row['log_data'] is not set and we access it. That's why we use ?? ''. btw: I ran some tests with blackfire and unserializing 'a:0:{}' is slower than ''. I guess it's because the inner c call returns early. With 100.000 runs, it was 20% slower and consumed 50% more cpu time. Of course, that's a stupid comparison but still the one is faster than the other. -
Alexander Schnitzler uploaded patch set 3 04/18/20, 15:32
-
Oliver Klee voted on patch set 3 CR +1 04/18/20, 15:35
-
TYPO3com voted on patch set 3 V +1 04/18/20, 15:45 Completed build in 12m 34s on Sat, 18 Apr, 03:44 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2812
-
Jonas Eberle commented on patch set 3 CR +1 04/18/20, 17:32
SeparateSysHistoryFromSysLogUpdate.php:174ReplyDone -
Josef Glatz voted on patch set 3 CR +1 04/21/20, 03:49
-
Josef Glatz voted on patch set 3 V +1 04/21/20, 05:46
-
Guido Schmechel voted on patch set 3 CR +1 04/21/20, 06:46
-
Wouter Wolters voted on patch set 3 CR +1 04/21/20, 07:00
-
Benni Mack commented on patch set 3 04/21/20, 10:31
SeparateSysHistoryFromSysLogUpdate.php:183there might be an issue here as well? -
Georg Großberger uploaded patch set 4 04/23/20, 08:18
-
Georg Großberger commented on patch set 4 04/23/20, 08:19
SeparateSysHistoryFromSysLogUpdate.php:183ReplyNot during the import, later possibly. Pushed a new patchset fix this too. -
TYPO3com voted on patch set 4 V -1 04/23/20, 08:29 Completed build in 11m 16s on Thu, 23 Apr, 08:29 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2990
-
Georg Großberger uploaded patch set 5 04/23/20, 08:55
-
TYPO3com voted on patch set 5 V +1 04/23/20, 09:06 Completed build in 11m 15s on Thu, 23 Apr, 09:06 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2991
-
Oliver Klee commented on patch set 5 CR -1 04/23/20, 09:08
SeparateSysHistoryFromSysLogUpdate.php:393Please let's use type declarations instead.SeparateSysHistoryFromSysLogUpdate.php:398Please let's not overwrite the variable here. Instead, please let's use another variable or directly return the value. -
Alexander Schnitzler commented on patch set 5 04/23/20, 10:54
SeparateSysHistoryFromSysLogUpdate.php:398ReplyI am in favor of direct return. -
Georg Großberger uploaded patch set 6 04/24/20, 09:16
-
Georg Großberger commented on patch set 6 04/24/20, 09:17
SeparateSysHistoryFromSysLogUpdate.php:393ReplyParameter $serialized cannot be typed. At least not until PHP 8.0. Added a return type though.SeparateSysHistoryFromSysLogUpdate.php:398ReplyDone -
Oliver Klee commented on patch set 6 04/24/20, 09:19
SeparateSysHistoryFromSysLogUpdate.php:393ReplyCan't it be "?string" (i.e., a nullable string)? -
Georg Großberger commented on patch set 6 04/24/20, 15:20
SeparateSysHistoryFromSysLogUpdate.php:393ReplyUnfortunatly not, can also be a boolean "false". -
Oliver Klee commented on patch set 6 04/24/20, 15:29
SeparateSysHistoryFromSysLogUpdate.php:393ReplyThen the @param annotation is incorrect and needs to be fixed. -
Oliver Klee commented on patch set 6 CR -1 04/25/20, 12:07
SeparateSysHistoryFromSysLogUpdate.php:392The type annotation still needs to be fixed. -
Jonas Eberle wrote 04/26/20, 11:58
Removed reviewer Jonas Eberle. -
Georg Großberger uploaded patch set 7 04/29/20, 11:21
-
Georg Großberger commented on patch set 7 04/29/20, 11:23
SeparateSysHistoryFromSysLogUpdate.php:392ReplyThanks for pointing that out. Did it a bit different now, please take a look at patchset 7. -
TYPO3com voted on patch set 7 V +1 04/29/20, 11:32 Completed build in 11m 19s on Wed, 29 Apr, 11:32 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3106
-
Oliver Klee voted on patch set 7 CR +1 04/29/20, 12:00
-
Benni Mack updated the commit message in patch set 8 05/25/20, 18:48
-
Daniel Goerz commented on patch set 8 10/09/20, 13:34
Please continue in the 10.4 branch as this Upgrade Wizard does not exist in master anymore https://review.typo3.org/c/Packages/TYPO3.CMS/+/66051 -
Daniel Goerz abandoned the change 10/09/20, 13:34
SeparateSysHistoryFromSysLogUpdate.php:174Unresolved