Review main Merged

64183[BUGFIX] Ignore includeNotInMenu for the section menu of the current page

Josef Glatz CR +2 V +2 Easy +10 −0 updated 04/21/20, 07:11

Commit message

The option includeNotMenu is set to 1 if the CType menu_section is used
to render a section menu for the current page even if the page is hidden
in menus (pages.nav_hide).

This patch adds also the necessary stdWrap functionality to the abstract
class for hierarchical menus.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1419

  1. Josef Glatz uploaded patch set 1 04/15/20, 11:59

  2. Josef Glatz commented on patch set 1 04/15/20, 12:00

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 04/15/20, 12:39 Completed build in 36m 02s on Wed, 15 Apr, 12:39 PM Test Summary: 8 of 74007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2574

  4. Josef Glatz commented on patch set 1 04/15/20, 13:47

    MenuSection.typoscript:12 Unresolved

    Just for clarification: We can use the stdWrap function override without assigning a default, since the default is already 0 for includeNotInMenu.
  5. TYPO3com voted on patch set 1 V +1 04/15/20, 13:50 Completed build in 44m 50s on Wed, 15 Apr, 01:50 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2579

  6. Oli Bartsch commented on patch set 1 04/15/20, 16:07

    AbstractMenuContentObject.php:245

    This should be `$this->conf['includeNotInMenu.'] ?? null`
  7. Josef Glatz commented on patch set 2 04/15/20, 16:29

    Published edit on patch set 1.
  8. Josef Glatz commented on patch set 2 04/15/20, 16:30

    AbstractMenuContentObject.php:245 Reply

    Done
  9. TYPO3com voted on patch set 2 V +1 04/15/20, 16:42 Completed build in 12m 58s on Wed, 15 Apr, 04:42 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2594

  10. Oli Bartsch uploaded patch set 3 04/17/20, 05:56

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 04/17/20, 05:57

  12. TYPO3com voted on patch set 3 V +1 04/17/20, 06:09 Completed build in 12m 07s on Fri, 17 Apr, 06:09 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2681

  13. Benni Mack voted on patch set 3 CR +1 04/17/20, 07:56

  14. Josef Glatz rebased onto patch set 4 04/20/20, 11:26

  15. Oli Bartsch voted on patch set 4 V +1 CR +1 04/20/20, 11:30

  16. TYPO3com voted on patch set 4 V +1 04/20/20, 11:43 Completed build in 14m 03s on Mon, 20 Apr, 11:43 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2892

  17. Benni Mack voted on patch set 4 V +2 CR +2 04/20/20, 12:44

  18. Benni Mack merged patch set 5 04/20/20, 12:44

  19. Josef Glatz commented on patch set 5 04/21/20, 07:11