Review main Merged

64186[TASK] Update rector/rector to 0.7.14

Alexander Schnitzler CR +2 V +2 Hard +207 −140 updated 04/15/20, 16:00

Commit message

composer remove rector/rector

Package operations: 0 installs, 8 updates, 4 removals
  - Removing tracy/tracy (v2.7.2)
  - Removing rector/rector (v0.7.0)
  - Removing phpstan/phpstan-phpunit (0.12.6)
  - Removing ondram/ci-detector (3.1.1)
  - Updating composer/xdebug-handler (1.4.0 => 1.4.1)
  - Updating nette/robot-loader (v3.2.1 => v3.2.3)
  - Updating symplify/package-builder (v7.2.2 => v7.2.12)
  - Updating symplify/auto-bind-parameter (v7.2.2 => v7.2.12)
  - Updating nette/http (v3.0.3 => v3.0.4)
  - Updating symplify/autowire-array-parameter (v7.2.2 => v7.2.12)
  - Updating symplify/smart-file-system (v7.2.2 => v7.2.12)
  - Updating symplify/set-config-resolver (v7.2.2 => v7.2.12)

composer require rector/rector:"^0.7.14" --dev

Package operations: 5 installs, 0 updates, 0 removals
  - Installing tracy/tracy (v2.7.4)
  - Installing phpstan/phpstan-phpunit (0.12.7)
  - Installing ondram/ci-detector (3.3.0)
  - Installing jetbrains/phpstorm-stubs (v2019.3)
  - Installing rector/rector (v0.7.14)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Alexander Schnitzler uploaded patch set 1 04/15/20, 14:00

  2. Oliver Klee commented on patch set 1 04/15/20, 14:04

    Should we also update the minimum required version in the composer.json? Or do we not rely on new features here?
  3. Alexander Schnitzler commented on patch set 1 CR -1 04/15/20, 14:08

    > Patch Set 1: > > Should we also update the minimum required version in the composer.json? Or do we not rely on new features here? We are actually relying more on bugfixes here than new features but I am also in for updating composer.json
  4. Alexander Schnitzler uploaded patch set 2 04/15/20, 14:15

  5. Oliver Klee voted on patch set 2 CR +1 04/15/20, 14:19

  6. TYPO3com voted on patch set 1 V +1 04/15/20, 14:33 Completed build in 22m 22s on Wed, 15 Apr, 02:33 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2585

  7. TYPO3com voted on patch set 2 V +1 04/15/20, 14:39 Completed build in 15m 51s on Wed, 15 Apr, 02:39 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2586

  8. Benni Mack voted on patch set 2 V +2 CR +2 04/15/20, 16:00

  9. Benni Mack merged patch set 3 04/15/20, 16:00